Skip to content

Fix Communication JobRouter Sample Issue#34116

Merged
lmazuel merged 2 commits intoAzure:mainfrom
jerryshia:issue33658
Aug 5, 2024
Merged

Fix Communication JobRouter Sample Issue#34116
lmazuel merged 2 commits intoAzure:mainfrom
jerryshia:issue33658

Conversation

@jerryshia
Copy link
Contributor

@jerryshia jerryshia commented Feb 2, 2024

Fixes issue #33658
@rohit-ganguly , @lmazuel , @lfraleigh , @mayurid , @sarkar-rajarshi for notification.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@v-xuto
Copy link
Member

v-xuto commented Feb 19, 2024

@rohit-ganguly , @lmazuel , @lfraleigh , @mayurid , @sarkar-rajarshi Could you help review this PR and merge it if it looks good?

@github-actions
Copy link

Hi @jerryshia. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Apr 26, 2024
@github-actions
Copy link

github-actions bot commented May 3, 2024

Hi @jerryshia. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this May 3, 2024
@v-xuto
Copy link
Member

v-xuto commented May 24, 2024

@rohit-ganguly , @lmazuel , @lfraleigh , @mayurid , @sarkar-rajarshi Could you help review this PR and merge it if it looks good?

@v-xuto v-xuto reopened this May 24, 2024
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label May 24, 2024
@v-xuto
Copy link
Member

v-xuto commented Jun 3, 2024

@sarkar-rajarshi Could you help merge this PR? Thank a lot.

Copy link
Contributor

@rohit-ganguly rohit-ganguly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for updating.

@sarkar-rajarshi
Copy link
Member

@v-xuto The ci is failing with lint errors

@jerryshia
Copy link
Contributor Author

jerryshia commented Jun 4, 2024

@sarkar-rajarshi
Copy link
Member

@lmazuel Could we get this PR merged in, while we address the lint errors in a separate PR? This PR simply updates some variable names in the samples?

@v-xuto
Copy link
Member

v-xuto commented Jul 15, 2024

@lmazuel Could we get this PR merged in, while we address the lint errors in a separate PR? This PR simply updates some variable names in the samples?

@lmazuel Any ideas?

@lmazuel
Copy link
Member

lmazuel commented Aug 5, 2024

Force merging, as the changes in this PR are ok

@lmazuel lmazuel merged commit 918f611 into Azure:main Aug 5, 2024
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants