Skip to content

[AutoPR] storage/resource-manager#3052

Merged
lmazuel merged 2 commits intomasterfrom
restapi_auto_storage/resource-manager
Aug 1, 2018
Merged

[AutoPR] storage/resource-manager#3052
lmazuel merged 2 commits intomasterfrom
restapi_auto_storage/resource-manager

Conversation

@AutorestCI
Copy link
Contributor

@AutorestCI AutorestCI commented Jul 31, 2018

Created to accumulate context: storage/resource-manager

@AutorestCI
[AutoPR storage/resource-manager] [Storage] Set the SignedResource as…
b80d986 
… optional in ListServiceSAS (#2967)

* Generated from 7882bc39a752f3adf4c47186c926094ab65cedc9

[Storage] Set the SignedResource as optional in ListServiceSAS

* Generated from b36d0991a7cc9a7185fc6b7d7ef6919f63435234

[Storage] Fix a format issue.
@AutorestCI AutorestCI requested a review from lmazuel as a code owner July 31, 2018 16:41
This was referenced Jul 31, 2018
Merged
Merged
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Jul 31, 2018 •
edited
Loading

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-storage

You can install the package azure-mgmt-storage of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_storage/resource-manager#egg=azure-mgmt-storage&subdirectory=azure-mgmt-storage"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_storage/resource-manager#egg=azure-mgmt-storage&subdirectory=azure-mgmt-storage"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_storage/resource-manager
  • pip install -e ./azure-mgmt-storage

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_storage/resource-manager
  • pip wheel --no-deps ./azure-mgmt-storage

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented Jul 31, 2018 •
edited
Loading

Codecov Report

Merging #3052 into master will decrease coverage by 1.46%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3052      +/-   ##
==========================================
- Coverage   57.41%   55.95%   -1.47%     
==========================================
  Files        7775     9026    +1251     
  Lines      158465   187161   +28696     
==========================================
+ Hits        90990   104727   +13737     
- Misses      67475    82434   +14959
Impacted Files Coverage Δ
...mgmt/storage/v2018_02_01/models/restriction_py3.py 55.55% <ø> (ø) ⬆️
...orage/v2018_02_01/models/service_sas_parameters.py 20.83% <ø> (ø) ⬆️
...ure/mgmt/storage/v2018_02_01/models/restriction.py 55.55% <ø> (ø) ⬆️
...mt/storage/v2018_02_01/models/operation_display.py 44.44% <0%> (-5.56%) ⬇️
...e/v2018_02_01/models/service_sas_parameters_py3.py 20.83% <100%> (ø) ⬆️
azure-mgmt-storage/azure/mgmt/storage/version.py 100% <100%> (ø) ⬆️
...torage/v2018_02_01/models/operation_display_py3.py 44.44% <50%> (-5.56%) ⬇️
...e/models/managed_cluster_agent_pool_profile_py3.py 27.58% <0%> (-8.13%) ⬇️
...rvice/models/managed_cluster_agent_pool_profile.py 27.58% <0%> (-8.13%) ⬇️
...t/compute/v2018_04_01/compute_management_client.py 35.44% <0%> (-7.9%) ⬇️
... and 1283 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0379912...a4d9c3d. Read the comment docs.

@lmazuel lmazuel merged commit 355e1c4 into master Aug 1, 2018
@lmazuel lmazuel deleted the restapi_auto_storage/resource-manager branch August 1, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees

No one assigned

Labels

ServicePR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AutorestCI @codecov-io @lmazuel