Adding in some functionality to use different clouds#28528
Merged
harneetvirk merged 25 commits intoAzure:mainfrom Feb 7, 2023
Merged
Adding in some functionality to use different clouds#28528harneetvirk merged 25 commits intoAzure:mainfrom
harneetvirk merged 25 commits intoAzure:mainfrom
Conversation
brownma-ms
requested review from
MilesHolland,
diondrapeck,
harneetvirk,
kdestin,
luigiw,
needuv,
nthandeMS,
paulshealy1 and
singankit
as code owners
ghost
added
Machine Learning
customer-reported
|
Thank you for your contribution brownma-ms! We will review the pull request and get back to you soon. |
|
Typo in item 1--SKD not SDK |
This support is needed for the air gapped environments. There are three ways to add a new cloud environment. These were all taken from examples in the v1 sdk. 1) The SDK will look for a default configuration file and try to find cloud environments in there. 2) If you set an environment variable called ARM_METADATA_URL, it will look there for cloud configurations. If you do not set this, it will use a default URL in the _azure_environments.py file to find them. 3) The SDK exposes two new functions, add_cloud which will add the new configuration to the configuration file mentioned in Azure#1, and update_cloud which will update the added configuration.
brownma-ms
force-pushed
the
brownma/moreclouds
branch
from
bea8b06 to
f5657de
Compare
ronalds-cmd
approved these changes
Jan 30, 2023
derekehyatt
reviewed
Jan 30, 2023
harneetvirk
reviewed
Jan 30, 2023
harneetvirk
reviewed
Jan 30, 2023
harneetvirk
reviewed
Jan 30, 2023
harneetvirk
reviewed
Jan 30, 2023
harneetvirk
reviewed
Jan 30, 2023
singankit
reviewed
Jan 30, 2023
singankit
reviewed
Jan 30, 2023
brownma-ms
force-pushed
the
brownma/moreclouds
branch
from
334a0f1 to
c1ccf82
Compare
brownma-ms
force-pushed
the
brownma/moreclouds
branch
3 times, most recently
from
dc2e596 to
4360dd6
Compare
theodoreschen
approved these changes
Feb 3, 2023
derekehyatt
reviewed
Feb 3, 2023
derekehyatt
reviewed
Feb 3, 2023
derekehyatt
reviewed
Feb 3, 2023
derekehyatt
reviewed
Feb 3, 2023
harneetvirk
reviewed
Feb 3, 2023
harneetvirk
reviewed
Feb 3, 2023
…sure all endpointurls are registered
…t region but region can be updated with environment variable
harneetvirk
reviewed
Feb 3, 2023
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
harneetvirk
reviewed
Feb 6, 2023
paulshealy1
reviewed
Feb 6, 2023
brownma-ms
force-pushed
the
brownma/moreclouds
branch
2 times, most recently
from
a308722 to
fdc9a96
Compare
brownma-ms
force-pushed
the
brownma/moreclouds
branch
from
fdc9a96 to
f94358e
Compare
harneetvirk
approved these changes
Feb 7, 2023
Contributor
harneetvirk
left a comment
harneetvirk
left a comment
There was a problem hiding this comment.
Let's add a sample for using this feature of loading new cloud if possible. It can be part of the following PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This support is needed for the air gapped environments. There are three ways to add a new cloud environment. These were all taken from examples in the v1 sdk.
cloud environments in there.
look there for cloud configurations. If you do not set this, it will
use a default URL in the _azure_environments.py file to find them.
configuration to the configuration file mentioned in number 1, and
update_cloud which will update the added configuration.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines