[Storage] Make lease duration tests less flakey#24930
Merged
jalauzon-msft merged 1 commit intoAzure:mainfrom Jun 22, 2022
Merged
[Storage] Make lease duration tests less flakey#24930jalauzon-msft merged 1 commit intoAzure:mainfrom
jalauzon-msft merged 1 commit intoAzure:mainfrom
Conversation
jalauzon-msft
requested review from
annatisch and
vincenttran-msft
as code owners
ghost
added
the
vincenttran-msft
approved these changes
Jun 21, 2022
Member
vincenttran-msft
left a comment
vincenttran-msft
left a comment
There was a problem hiding this comment.
Thanks for this! Be gone red!
Collaborator
|
API change check API changes are not detected in this pull request. |
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 27, 2022
…into merge_patch * 'main' of https://github.com/Azure/azure-sdk-for-python: (155 commits) {machine learning} || Fix a bug in the code (Azure#24922) [CLU] support for AAD + docs (Azure#24960) Update dpg version (Azure#24986) [Botservice]fix model (Azure#24971) [perf] Add pipeline template and storage pipelines (Azure#24894) [Storage] Remove client-side encryption code from shared (Azure#24931) [EventHubs&ServiceBus] update docker images to internal (Azure#24966) Sync eng/common directory with azure-sdk-tools for PR 3481 (Azure#24964) [Dpg] update to use global autorest version (Azure#24970) [CLU] release updates + fix tests (Azure#24963) [Test Proxy] Add method to reset setting customizations (Azure#24952) [Storage] Add proxy-supporting test classes (Azure#24937) [Confidential Ledger] Enable live testing (Azure#24912) fix type of _SansIOHTTPPolicyRunner (Azure#24932) Adding SIP routing functionality to PhoneNumbers SDK (Azure#22805) [DPG] update quick-start-tool (Azure#24942) [formrecognizer] Enable copy model tests (Azure#24917) [CLU] remove maxpagesize (Azure#24949) Use westus3 for translation live tests (Azure#24947) [Storage] Make lease duration tests less flakey (Azure#24930) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change aims to make some tests that rely on a lease expiring less flaky by slightly increasing the sleep time that is used to wait for the lease to expire. Previously the sleep time was exactly equal to the lease duration which meant sometimes the lease would not expire in time during pipeline execution (likely due to clock skew and other timing issues). This change just adds a 2 second buffer to ensure there is enough time for the lease to expire.