migrate identity tests to test proxy#22537
Merged
xiangyan99 merged 28 commits intomainfrom Jul 22, 2022
Merged
Conversation
ghost
added
the
xiangyan99
requested review from
benbp,
mccoyp,
scbedd and
schaabs
as code owners
mccoyp
reviewed
Apr 11, 2022
Collaborator
|
API change check for API changes are not detected in this pull request for |
mccoyp
reviewed
Apr 12, 2022
Member
mccoyp
left a comment
mccoyp
left a comment
There was a problem hiding this comment.
This is looking really good, thank you!
...ity/azure-identity/tests/recordings/test_imds_credential.pyTestImdstest_system_assigned.json
Outdated
Show resolved
Hide resolved
Co-authored-by: McCoy Patiño <[email protected]>
xiangyan99
removed request for
BigCat20196,
YalinLi0312,
abhahn,
anilba06,
cRui861,
catalinaperalta,
gkostal,
iscai-msft,
kristapratico,
lmazuel,
msyyc,
paterasMSFT,
scbedd,
schaabs,
weshaggard and
zfengms
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
mccoyp
approved these changes
Jul 21, 2022
Member
mccoyp
left a comment
mccoyp
left a comment
There was a problem hiding this comment.
LGTM! You should now be able to use the new recording fixture if you want, which would only involve replacing the @recorded_by_proxy decorators with a recorded_test fixture request (the rest of the test proxy tooling works the same).
I would recommend doing so now so you don't have to later, but this PR has also been up for a while so I won't block you on this 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines