Skip to content

[AutoPR] redis/resource-manager#2091

Merged
lmazuel merged 8 commits intomasterfrom
restapi_auto_redis/resource-manager
Jan 15, 2019
Merged

[AutoPR] redis/resource-manager#2091
lmazuel merged 8 commits intomasterfrom
restapi_auto_redis/resource-manager

Conversation

@AutorestCI
Copy link
Contributor

@AutorestCI AutorestCI commented Mar 2, 2018

Created to accumulate context: redis/resource-manager

@AutorestCI AutorestCI requested a review from lmazuel as a code owner March 2, 2018 20:36
@AutorestCI AutorestCI mentioned this pull request Mar 2, 2018
Merged
10 tasks
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Mar 2, 2018 •
edited
Loading

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-redis

You can install the package azure-mgmt-redis of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_redis/resource-manager#egg=azure-mgmt-redis&subdirectory=azure-mgmt-redis"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_redis/resource-manager#egg=azure-mgmt-redis&subdirectory=azure-mgmt-redis"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_redis/resource-manager
  • pip install -e ./azure-mgmt-redis

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_redis/resource-manager
  • pip wheel --no-deps ./azure-mgmt-redis

Direct download

Your files can be directly downloaded here:

@AutorestCI AutorestCI mentioned this pull request Mar 2, 2018
Merged
10 tasks
@lmazuel
Copy link
Member

lmazuel commented Mar 7, 2018

@AutorestCI rebase

@AutorestCI
[AutoPR redis/resource-manager] Swagger completeness for Redis Cache (#…
a05884c 
…2055)

* Generated from adccbe159e32ef8112a0aadccc07d3c6c5390d11

Name change for notification

* Generated from fdcb7d3837ae11e3fe8af22e28dadb032c498672

Fixing code review comments in PR
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Mar 7, 2018

Rebase done and pushed to the branch

@AutorestCI AutorestCI force-pushed the restapi_auto_redis/resource-manager branch from ce9aa1a to a05884c Compare March 7, 2018 18:05
@codecov-io
Copy link

codecov-io commented Mar 7, 2018 •
edited
Loading

Codecov Report

Merging #2091 into master will decrease coverage by <.01%.
The diff coverage is 42.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2091      +/-   ##
==========================================
- Coverage   53.08%   53.07%   -0.01%     
==========================================
  Files        4774     4777       +3     
  Lines      119517   119605      +88     
==========================================
+ Hits        63440    63485      +45     
- Misses      56077    56120      +43
Impacted Files Coverage Δ
...ure-mgmt-redis/azure/mgmt/redis/models/__init__.py 100% <100%> (ø) ⬆️
...is/azure/mgmt/redis/operations/redis_operations.py 29.2% <28.81%> (+0.36%) ⬆️
...mt-redis/azure/mgmt/redis/operations/operations.py 43.75% <50%> (+1.81%) ⬆️
...mgmt/redis/operations/firewall_rules_operations.py 21.97% <50%> (+3.58%) ⬆️
.../mgmt/redis/operations/linked_server_operations.py 21.69% <50%> (+3.07%) ⬆️
...is/azure/mgmt/redis/models/upgrade_notification.py 55.55% <55.55%> (ø)
...redis/models/check_name_availability_parameters.py 57.14% <57.14%> (ø)
...gmt/redis/operations/patch_schedules_operations.py 27.14% <57.14%> (+4.41%) ⬆️
...re/mgmt/redis/models/notification_list_response.py 62.5% <62.5%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f262d80...a05884c. Read the comment docs.

@AutorestCI AutorestCI mentioned this pull request Apr 27, 2018
Merged
10 tasks
@AutorestCI
[AutoPR redis/resource-manager] Improve redis Swagger. (#2485)
ec66ebf 
* Generated from d7abeaa6ae57648be6ecde4bc11c226d9c85166c

Improve redis Swagger. Documenting list all patchSchedules to fix #2968. Documenting the CheckNameAvailability.type property better to fix #2967. And use a realistic timespan value in PatchSchedule examples.

* Generated from 4f7e77b990601e0cc00b69a5870b50157525364d

Implementing suggested usability improvement for redis cache: by not modelling CheckNameAvailabilityParameters.resourceType as a string, it can instead be treated as a cosntant, so that the parameter becomes optional!

* Generated from 44e3bae7be1e5d63ad1531c7710d586f47405970

Backport to the Microsoft.cache/redis 2017-10-01 swagger (from 2018-03-01).
@AutorestCI AutorestCI mentioned this pull request May 3, 2018
Merged
@AutorestCI AutorestCI mentioned this pull request Dec 4, 2018
Merged
@AutorestCI
[AutoPR redis/resource-manager] typo: redis/resource-manager/Microsof…
1e34754 
…t.Cache (#3984)

* Generated from 5c7c95d799e03d2c657ef9b8864b02e26f895949

typo: redis/resource-manager/Microsoft.Cache

- subid -> subscriptionId
- properites -> properties
- occured -> occurred
- Trim trailing space

* Packaging update of azure-mgmt-redis
@AutorestCI AutorestCI mentioned this pull request Dec 4, 2018
Merged
@lmazuel
Copy link
Member

lmazuel commented Jan 15, 2019

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/blob/master/specification/redis/resource-manager/readme.md

@AutorestCI
Copy link
Contributor Author

AutorestCI commented Jan 15, 2019

Build SDK finished and cleaned

@lmazuel lmazuel merged commit 9d8931b into master Jan 15, 2019
@lmazuel lmazuel deleted the restapi_auto_redis/resource-manager branch January 15, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees

No one assigned

Labels

ServicePR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AutorestCI @lmazuel @codecov-io