Closed
Conversation
This was referenced Sep 14, 2021
Closed
heaths
reviewed
Sep 15, 2021
|
|
||
| def send_request( | ||
| self, | ||
| request, # type: HttpRequest |
Member
There was a problem hiding this comment.
This seems rather LLC-ish. I thought we were doing value-add methods here, or is this Python's fallback support for LLCs on every client (something .NET sorely lacks).
Contributor
There was a problem hiding this comment.
@heaths this is by design. Going forward, we want all of our python SDKs, regardless of how much convenience they have, to have a send_request method to break the glass
Member
There was a problem hiding this comment.
I did add an AnalyzeConversation (singular, note, after internal discussion - their operationId is plural even though you can only analyze one utterance) method as seen here: Azure/azure-sdk-for-net#24030
I also had to rename a couple models but requested that the swagger do so.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.