Search: Skill Versions#20431
Merged
tjprescott merged 17 commits intoAzure:mainfrom Sep 3, 2021
tjprescott:tjprescott/SearchSkillVersion
Merged
Search: Skill Versions#20431tjprescott merged 17 commits intoAzure:mainfrom tjprescott:tjprescott/SearchSkillVersion
tjprescott merged 17 commits intoAzure:mainfrom
tjprescott:tjprescott/SearchSkillVersion
Conversation
ghost
added
the
xiangyan99
reviewed
Aug 27, 2021
sdk/search/azure-search-documents/azure/search/documents/indexes/models/__init__.py
Outdated
Show resolved
Hide resolved
xiangyan99
reviewed
Aug 27, 2021
sdk/search/azure-search-documents/azure/search/documents/indexes/models/__init__.py
Outdated
Show resolved
Hide resolved
xiangyan99
reviewed
Aug 27, 2021
sdk/search/azure-search-documents/azure/search/documents/indexes/models/_models.py
Outdated
Show resolved
Hide resolved
xiangyan99
reviewed
Aug 27, 2021
sdk/search/azure-search-documents/azure/search/documents/indexes/models/_models.py
Outdated
Show resolved
Hide resolved
xiangyan99
reviewed
Aug 27, 2021
Member
xiangyan99
left a comment
xiangyan99
left a comment
There was a problem hiding this comment.
Seems like we missed the de-serialization part.
SearchIndexerSkillset.skills is [SearchIndexerSkill].
It seems to me we also need to customize SearchIndexerSkillset so if its skills contains EntityRecognitionSkill/SentimentSkill. We need to map them into our fancy Skills.
xiangyan99
reviewed
Aug 31, 2021
sdk/search/azure-search-documents/azure/search/documents/indexes/models/_models.py
Outdated
Show resolved
Hide resolved
xiangyan99
reviewed
Aug 31, 2021
Member
xiangyan99
left a comment
xiangyan99
left a comment
There was a problem hiding this comment.
nit: I think this change should not impact any network request/response. So no need to re-record the tests. Of course, there is no harm to do so.
xiangyan99
reviewed
Aug 31, 2021
sdk/search/azure-search-documents/azure/search/documents/indexes/models/_models.py
Outdated
Show resolved
Hide resolved
Member
Author
|
I had to re-record the tests because I needed to change the skillset tests... and then re-recorded all to ensure I didn't accidentally break anything. |
Member
Author
|
@annatisch @xiangyan99 I created an issue to track the client-side validation aspects: #20526 |
xiangyan99
approved these changes
Sep 3, 2021
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Sep 7, 2021
…into switch_to_protocol * 'main' of https://github.com/Azure/azure-sdk-for-python: (53 commits) Smoke test package verification (Azure#20547) Update CHANGELOG.md (Azure#20569) updating codeowners (Azure#20570) Simplify recorded OnBehalfOfCredential tests (Azure#20568) Search: update release date (Azure#20564) [Exporter] Support redirect response in exporter (Azure#20489) [AutoRelease] t2-synapse-2021-09-06-18774 (Azure#20552) [AutoRelease] t2-logz-2021-08-26-01773 (Azure#20426) [AutoRelease] t2-relay-2021-09-03-32777 (Azure#20530) [AutoRelease] t2-resource-2021-09-03-61345 (Azure#20527) [AutoRelease] t2-servicefabric-2021-09-02-41879 (Azure#20512) [Keyvault] Remove exception message parsing from samples in keys, certificates and secrets (Azure#20540) [ACR] Update cloud configuration API (Azure#20464) Get rid of generated code (Azure#20536) Search: Skill Versions (Azure#20431) Check fd is reg file or symlink in get_length before using st_size. (Azure#19725) Add OnBehalfOfCredential (Azure#20451) Fix incorrect parsing of message from Exception (Azure#20534) [Release sdk status] swagger repo default branch changes to `main` (Azure#20529) [AutoRelease] t2-rdbms-2021-09-02-91864 (Azure#20513) ...
iscai-msft
pushed a commit
that referenced
this pull request
Sep 29, 2021
* Initial commit. * Add docstrings for skill_version * Ensure SearchIndexerSkillset can convert between custom and generated models. * Update tests. * Fix async skillsets and tests. * Add client-side validation and tests for model properties. * Re-record tests. * Fix pylint errors. * Rerecord tests. Fix linter errors. * Fix ordering on old Python version. * Add changelog entry. * Fix linter issues. Make enums NOT case insensitive due to pylint failure. * Remove client-side validation. Update models. * Update test and re-record skillset tests. * Change :param annotations to :ivar for custom models. * Rename SearchField normalizer to normalizer_name. * Restore :param annotation for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20432.
Adds
SentimentSkillVersionandEntityRecognitionSkillVersion, and a customized model forSentimentSkillandEntityRecognitionSkillthat uses this version to create the correct model.