Skip to content

[Key Vault] Add perf tests for certificates, keys, and secrets#17073

Merged
mccoyp merged 5 commits intoAzure:masterfrom
mccoyp:perfstress-tests
Mar 5, 2021
Merged

[Key Vault] Add perf tests for certificates, keys, and secrets#17073
mccoyp merged 5 commits intoAzure:masterfrom
mccoyp:perfstress-tests

Conversation

@mccoyp
Copy link
Member

@mccoyp mccoyp commented Mar 3, 2021

Resolves #16888.

This adds one performance test for each package, testing the get_* function for each. Instructions for writing these tests can be found here.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. test enhancement labels Mar 3, 2021
@mccoyp mccoyp added this to the [2021] March milestone Mar 3, 2021
@mccoyp mccoyp requested review from chlowell and schaabs as code owners March 3, 2021 21:54
@@ -0,0 +1,48 @@
from azure_devtools.perfstress_tests import PerfStressTest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a license header

tenant_id = self.get_from_env("AZURE_TENANT_ID")
client_id = self.get_from_env("AZURE_CLIENT_ID")
client_secret = self.get_from_env("AZURE_CLIENT_SECRET")
self.credential = ClientSecretCredential(tenant_id, client_id, client_secret)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use EnvironmentCredential, if you don't mind being less explicit

@mccoyp mccoyp merged commit 1025c0b into Azure:master Mar 5, 2021
@mccoyp mccoyp deleted the perfstress-tests branch March 5, 2021 22:25
iscai-msft added a commit that referenced this pull request Mar 8, 2021
…into update_ta_tests

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  Update get_package_properties.py logic for python 2.7 (#17144)
  update changelog (#17150)
  [ServiceBus] 7.1.0 Release update changelog (#17135)
  [ServiceBus] Object mapping support (#17080)
  move SetTestPipeline into its own template (#17141)
  Revise token cache configuration API (#16326)
  Fix dup cloud error (#17097)
  Perf tests for monitor exporter (#17067)
  [Communication] - Phone Number - Redesigned API (#16671)
  disable retry (#17078)
  [Key Vault] Add perf tests for certificates, keys, and secrets (#17073)
  [text analytics] Analyze updates for v5.1.0b6 (#17003)
  Add any additional claims to AuthenticationRequiredError (#17136)
  Fix logic in SetTestPipelineVersionInEngCommon (#17138)
  [Key Vault] Make test resource cleanup script asynchronous (#17032)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Key Vault] Add at least one perf test for certs, keys, and secrets

2 participants