Merged
Conversation
ghost
added
the
Contributor
Author
|
/azp run python - eventgrid - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run python - eventgrid - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run python - eventgrid - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rakshith91
requested review from
lmazuel,
swathipil and
yunhaoling
as code owners
yunhaoling
reviewed
Mar 3, 2021
| self, | ||
| topic_hostname: str, | ||
| events: List["models.EventGridEvent"], | ||
| events: List["_models.EventGridEvent"], |
Contributor
There was a problem hiding this comment.
random question: how would this be rendered on doc/type hint?
wondering if users would get confused that how they create EventGridEvent from _models module.
(ignore me if this could be rendered corrected by python/sphinx)
Contributor
Author
There was a problem hiding this comment.
I'm not much concerned about this - this is an autogenerated method from swagger which is not used anywhere in our code. (we just need this in the swagger for the sake of other languages)
yunhaoling
reviewed
Mar 3, 2021
| """ | ||
|
|
||
| ACSChatMemberAddedToThreadWithUserEventName = ( | ||
| AcsChatMemberAddedToThreadWithUserEventName = ( |
Contributor
There was a problem hiding this comment.
Is this something public in the previous release?
naming change seems to be a breaking change to me (although it's just ACS* to Acs*, probably something worth to mention in the changelog.
If those are just added in this release, then I have no concern.
Contributor
Author
There was a problem hiding this comment.
i was on fence to add this in the changelog, but i agree -updated
yunhaoling
approved these changes
Mar 3, 2021
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 3, 2021
…into http_request_json * 'master' of https://github.com/Azure/azure-sdk-for-python: (147 commits) [text analytics] add perf tests (Azure#17060) Add cloud event to core (Azure#16800) [Perf] Small fixes to storage-blob (Azure#17055) [EG] Regenerate Code (Azure#17053) Scrub batch shared keys (Azure#17030) [Tables] Add SAS to tables (Azure#16717) T2 containerservice 2021 03 03 (Azure#17050) Addressing issues with CredScan (Azure#16944) Communication chat preview4 (Azure#16905) (Azure#17037) remove first query section (Azure#17033) [formrecognizer] temp disable sample tests until service bug fixed (Azure#17036) [device update] allow device update pylint failures (Azure#17034) fix build (Azure#17029) update artifact names for ALL packages to align with the actual package name Create azure-iot-nspkg (Azure#17026) [Communication]: SMS 1:N Messages, Custom Tags, and Idempotence (Azure#16836) Fixing credentials to use AAD (Azure#16885) T2 deviceupdate 2021 03 02 (Azure#17016) T2 cosmosdb 2021 02 23 (Azure#16875) T2 datadog 2021 03 02 (Azure#17004) ...
iscai-msft
added a commit
that referenced
this pull request
Mar 3, 2021
…into add_sample_check * 'master' of https://github.com/Azure/azure-sdk-for-python: (388 commits) [text analytics] add normalized_text (#17074) Renaming with_token identity function (#17066) Adapt to azure core's cloud event (#17063) align perf tests with js (#17069) [Perfstress][Storage] Added FileShare perf tests (#15834) [formrecognizer] Adding custom forms perf test (#16969) Fix LanguageShort typo (#17068) sas creds updates (#17065) [eventgrid] Fix Sample eh (#17064) [Perfstress][Storage] Added Datalake perf tests (#15861) [text analytics] Healthcare n-ary relations (#16997) ServiceBus dict-representation acceptance and kwarg-update functionality (#14807) [text analytics] add perf tests (#17060) Add cloud event to core (#16800) [Perf] Small fixes to storage-blob (#17055) [EG] Regenerate Code (#17053) Scrub batch shared keys (#17030) [Tables] Add SAS to tables (#16717) T2 containerservice 2021 03 03 (#17050) Addressing issues with CredScan (#16944) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 4, 2021
…into add_query_kwarg * 'master' of https://github.com/Azure/azure-sdk-for-python: (69 commits) march release (Azure#16966) Release of Device Update for IoT Hub SDK for Python. (Azure#17005) Add Get-AllPackageInfoFromRepo (Azure#16947) Track1 package is incorrectly set as track2 (Azure#17075) [text analytics] add normalized_text (Azure#17074) Renaming with_token identity function (Azure#17066) Adapt to azure core's cloud event (Azure#17063) align perf tests with js (Azure#17069) [Perfstress][Storage] Added FileShare perf tests (Azure#15834) [formrecognizer] Adding custom forms perf test (Azure#16969) Fix LanguageShort typo (Azure#17068) sas creds updates (Azure#17065) [eventgrid] Fix Sample eh (Azure#17064) [Perfstress][Storage] Added Datalake perf tests (Azure#15861) [text analytics] Healthcare n-ary relations (Azure#16997) ServiceBus dict-representation acceptance and kwarg-update functionality (Azure#14807) [text analytics] add perf tests (Azure#17060) Add cloud event to core (Azure#16800) [Perf] Small fixes to storage-blob (Azure#17055) [EG] Regenerate Code (Azure#17053) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.