Merged
Conversation
kristapratico
commented
Mar 3, 2021
* [samples] added 'batch_translation_async' sample * [samples] added 'batch_translation_with_storage_async' sample * [samples] added remianing async samples * [samples] update file names * [samples] added self to instance methods * [samples][async] fix import textanalytics :) * [samples] fix self. when calling instance methods * [samples] fixed async check status to use AsyncItemPaged used in Async Client * [samples] async -> some async operations instead of sync ones * [samples][async] use async blob operations * [samples][async] blob download async * [samples][async] check_documents async * [samples][async] added some missing await methods * [async samples] change await time to recommended period * [samples] updated async samples to comply with new changes
kristapratico
requested review from
danieljurek,
lmazuel,
mayurid and
mitchdenny
as code owners
kristapratico
requested review from
maririos
and removed request for
danieljurek,
lmazuel,
mayurid and
mitchdenny
maririos
approved these changes
Mar 4, 2021
Member
maririos
left a comment
maririos
left a comment
There was a problem hiding this comment.
Only clarifying comment is pipeline and running samples
| @@ -0,0 +1,3 @@ | |||
| # Release History | |||
|
|
|||
| ## 1.0.0b1 (Unreleased) | |||
| @@ -0,0 +1,3 @@ | |||
| # Release History | |||
Member
There was a problem hiding this comment.
does the folder need to match the namespace? just wondering if this should be in translation or something else.
For now it is fine
Contributor
Author
There was a problem hiding this comment.
Still part of the larger namespace issue. Might move around later.
| ) | ||
|
|
||
| @distributed_trace | ||
| def create_translation_job(self, batch, **kwargs): |
| long_description=long_description, | ||
| url='https://github.com/Azure/azure-sdk-for-python', | ||
| author='Microsoft Corporation', | ||
| author_email='[email protected]', |
Contributor
Author
There was a problem hiding this comment.
This was just copied straight from our template package
| trigger: none | ||
|
|
||
| jobs: | ||
| - template: ../../eng/pipelines/templates/jobs/archetype-sdk-tests.yml |
Member
There was a problem hiding this comment.
will this add a pipeline for nightly test? will the samples start running?
I just wonder how the cleanup of the target container will work
Contributor
Author
There was a problem hiding this comment.
No, only the ci pipeline will be created for recorded tests. We still need to figure out how we'll do creation/tear down of live resources. I'm going to look into that today a bit.
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 5, 2021
…into assertions * 'master' of https://github.com/Azure/azure-sdk-for-python: [core] add HttpRequest and HttpResponse reprs (Azure#16972) [text analytics] add actual normalized_text tests (Azure#17123) update samples to use actual role names (Azure#17124) Sync eng/common directory with azure-sdk-tools for PR 1448 (Azure#17085) Enable APIView status check (Azure#17107) Fix PackageName typo (Azure#17109) Move SetTestPipelineVersion.ps1 to eng/common (Azure#17103) Fix paths for non-windows agents (Azure#17096) [Communication] - Identity - Update README (Azure#17091) Rename CertificateCredential's certificate_bytes -> certificate_data (Azure#17090) fix shared reqs (Azure#17095) [translation] initial library (Azure#16837) EG - more docs imrpovement (Azure#17079) [EventHubs] add logging.info to warn the usage of partition key of non-string type (Azure#17057) march release (Azure#16966) Release of Device Update for IoT Hub SDK for Python. (Azure#17005) Add Get-AllPackageInfoFromRepo (Azure#16947) Track1 package is incorrectly set as track2 (Azure#17075)
iscai-msft
added a commit
to abhahn/azure-sdk-for-python
that referenced
this pull request
Mar 5, 2021
…into ta-v5.1.0b6-analyze * 'master' of https://github.com/Azure/azure-sdk-for-python: (24 commits) [text analytics] PII updates for v5.1.0b6 (Azure#17038) Fix bug where imported matrix parameter duplicates are not overrided (Azure#17126) Add NULL to readme (Azure#17076) Sas batching (Azure#17133) dropping py3.5 (Azure#17127) [EventHubs] 5.3.1 update changelog (Azure#17132) [text analytics] assertions (Azure#17098) add recordings (Azure#17125) [core] add HttpRequest and HttpResponse reprs (Azure#16972) [text analytics] add actual normalized_text tests (Azure#17123) update samples to use actual role names (Azure#17124) Sync eng/common directory with azure-sdk-tools for PR 1448 (Azure#17085) Enable APIView status check (Azure#17107) Fix PackageName typo (Azure#17109) Move SetTestPipelineVersion.ps1 to eng/common (Azure#17103) Fix paths for non-windows agents (Azure#17096) [Communication] - Identity - Update README (Azure#17091) Rename CertificateCredential's certificate_bytes -> certificate_data (Azure#17090) fix shared reqs (Azure#17095) [translation] initial library (Azure#16837) ...
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Nov 23, 2021
containerservice-multiapi-config (Azure#16837) * update * Update readme.python.md * Update readme.md Co-authored-by: Yuchao Yan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the most updated generated code and a thin convenience layer /skeleton for the client and models.
APIView: https://apiview.dev/Assemblies/Review/019355482c6245a5a404eef64740da1e