[Communication] Generate identifier Models from new swagger#16735
Merged
sacheu merged 4 commits intofeature/preview4from Feb 16, 2021
Merged
[Communication] Generate identifier Models from new swagger#16735sacheu merged 4 commits intofeature/preview4from
sacheu merged 4 commits intofeature/preview4from
Conversation
sacheu
requested review from
a team,
ankitarorabit,
memontic-ms and
turalf
as code owners
ghost
added
the
sacheu
requested review from
JoshuaLai,
RezaJooyandeh,
minnieliu and
sarkar-rajarshi
RezaJooyandeh
approved these changes
Feb 16, 2021
RezaJooyandeh
requested changes
Feb 16, 2021
| # -------------------------------------------------------------------------- | ||
|
|
||
| from .models import ( | ||
| from .._generated.models import ( |
Member
There was a problem hiding this comment.
This file should be moved out of the shared folder. The shared folder across all packages should be identical. Considering that we are removing the models from the shared folder, we should move this class to the non-shared part of the chat code as well
Author
There was a problem hiding this comment.
Thanks. Updated in new iteration.
RezaJooyandeh
approved these changes
Feb 16, 2021
turalf
pushed a commit
that referenced
this pull request
Feb 20, 2021
* Add generated chat code from new swagger * Change to use new generated code * Address PR Feedback * Remove CommunicationUserIdentifierModel in identity,phone number package
juancamilor
pushed a commit
that referenced
this pull request
Mar 3, 2021
* [Communication] Generate identifier Models from new swagger (#16735) * Add generated chat code from new swagger * Address PR Feedback * Remove CommunicationUserIdentifierModel in identity,phone number package * Check schema of the object to determine the type [preview4] (#16838) * Replace identifier with rawId * Change serilizer * Replace indentifier with rawId in test code * Sync models across modules * fix typo in serizliser * Rearrange imports * Replace rawId with raw_id * remove trailing newline Co-authored-by: turalf <[email protected]> * preview4 changes made + unit tests fixed * Chat - preview4 changes - CommunicationUserIdentifier models added - create_chat_thread - returns CreateChatThreadResult instead of ChatThreadClient - add_participant - docstring update AddChatParticipantsResult instead of None - add_participants - docstring update AddChatParticipantsResult instead of None * pylint-changes * pylint changes * Method signature changed for add_pariticipant and add_participants - add_participant - AddChatParticipantsResult -> tuple(ChatThreadParticipant, CommunicationError) - add_participants - AddChatParticipantsResult -> list(tuple(ChatThreadParticipant, CommunicationError)) - unit tests modified as per signature change - CommunicationErrorResponseConverter added to cosolidate list(ChatThreadParticipant) and list(CommunicationError) into list(tuple(ChatThreadParticipant, CommunicationError)) - e2e tests modified as per signature change * CreateChatThreadResult modified to handle partial errors in batch calls with ease - CreateChatThreadResult -> attributes changed to - chat_thread -> ChatThread (no change) - Errors -> CreateChatThreadErrors -> list(tuple(ChatThreadParticipant, CommunicationError)) - create_chat_thread -> `thread_participants` and `repeatability_request_id` changed to keyword arguments - Modify unit tests to capture method signature modifications - Modify e2e tests to capture method signature modifications * pylint-changes * pylint fixes * README.md update + pylint fixes * test recordings added * add_participant -> raises error - Update README.md with modified signature - Update samples with new method signatures - Add test to detect invalid instantiation of AccessToken - Minor documentation updates - Modify unit tests to capture method signature modifications - Modify e2e tests to capture method signature modifications * pylint fixes * cls removed from docstring + update_topic async refactored * cls removed from docstring Co-authored-by: Sam Cheung <[email protected]> Co-authored-by: turalf <[email protected]> Co-authored-by: turalf <[email protected]>
juancamilor
pushed a commit
that referenced
this pull request
Mar 3, 2021
* [Communication] Generate identifier Models from new swagger (#16735) * Add generated chat code from new swagger * Address PR Feedback * Remove CommunicationUserIdentifierModel in identity,phone number package * Check schema of the object to determine the type [preview4] (#16838) * Replace identifier with rawId * Change serilizer * Replace indentifier with rawId in test code * Sync models across modules * fix typo in serizliser * Rearrange imports * Replace rawId with raw_id * remove trailing newline Co-authored-by: turalf <[email protected]> * preview4 changes made + unit tests fixed * Chat - preview4 changes - CommunicationUserIdentifier models added - create_chat_thread - returns CreateChatThreadResult instead of ChatThreadClient - add_participant - docstring update AddChatParticipantsResult instead of None - add_participants - docstring update AddChatParticipantsResult instead of None * pylint-changes * pylint changes * Method signature changed for add_pariticipant and add_participants - add_participant - AddChatParticipantsResult -> tuple(ChatThreadParticipant, CommunicationError) - add_participants - AddChatParticipantsResult -> list(tuple(ChatThreadParticipant, CommunicationError)) - unit tests modified as per signature change - CommunicationErrorResponseConverter added to cosolidate list(ChatThreadParticipant) and list(CommunicationError) into list(tuple(ChatThreadParticipant, CommunicationError)) - e2e tests modified as per signature change * CreateChatThreadResult modified to handle partial errors in batch calls with ease - CreateChatThreadResult -> attributes changed to - chat_thread -> ChatThread (no change) - Errors -> CreateChatThreadErrors -> list(tuple(ChatThreadParticipant, CommunicationError)) - create_chat_thread -> `thread_participants` and `repeatability_request_id` changed to keyword arguments - Modify unit tests to capture method signature modifications - Modify e2e tests to capture method signature modifications * pylint-changes * pylint fixes * README.md update + pylint fixes * test recordings added * add_participant -> raises error - Update README.md with modified signature - Update samples with new method signatures - Add test to detect invalid instantiation of AccessToken - Minor documentation updates - Modify unit tests to capture method signature modifications - Modify e2e tests to capture method signature modifications * pylint fixes * cls removed from docstring + update_topic async refactored * cls removed from docstring Co-authored-by: Sam Cheung <[email protected]> Co-authored-by: turalf <[email protected]> Co-authored-by: turalf <[email protected]> Co-authored-by: Sam Cheung <[email protected]> Co-authored-by: turalf <[email protected]> Co-authored-by: turalf <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.