[Key Vault] Add new encryption algorithms for 7.2-preview#16566
Merged
mccoyp merged 28 commits intoAzure:masterfrom Feb 10, 2021
Merged
[Key Vault] Add new encryption algorithms for 7.2-preview#16566mccoyp merged 28 commits intoAzure:masterfrom
mccoyp merged 28 commits intoAzure:masterfrom
Conversation
mccoyp
added
KeyVault
Client
chlowell
reviewed
Feb 5, 2021
sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_models.py
Outdated
Show resolved
Hide resolved
mccoyp
force-pushed
the
keys-algs-pr
branch
2 times, most recently
from
e7d3837 to
147a92d
Compare
chlowell
reviewed
Feb 5, 2021
sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/client_base.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py
Outdated
Show resolved
Hide resolved
chlowell
reviewed
Feb 5, 2021
sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py
Outdated
Show resolved
Hide resolved
chlowell
reviewed
Feb 5, 2021
sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py
Outdated
Show resolved
Hide resolved
chlowell
reviewed
Feb 6, 2021
...lt/azure-keyvault-keys/tests/recordings/test_crypto_client.test_decrypt_valid_arguments.yaml
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/aio/_client.py
Outdated
Show resolved
Hide resolved
chlowell
reviewed
Feb 9, 2021
sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py
Outdated
Show resolved
Hide resolved
chlowell
reviewed
Feb 9, 2021
| key = JsonWebKey( | ||
| kty="oct-HSM", | ||
| key_ops=["encrypt", "decrypt", "wrapKey", "unwrapKey"], | ||
| k=bytes.fromhex("e27ed0c84512bbd55b6af434d237c11feba311870f80f2c2e3364260f31c82c8"), |
Member
There was a problem hiding this comment.
Suggested change
| k=bytes.fromhex("e27ed0c84512bbd55b6af434d237c11feba311870f80f2c2e3364260f31c82c8"), | |
| k=binascii.unhexlify("e27ed0c84512bbd55b6af434d237c11feba311870f80f2c2e3364260f31c82c8"), |
Member
Author
There was a problem hiding this comment.
I was just about to push a switch to codecs.decode -- is binascii preferred?
Member
There was a problem hiding this comment.
No. I like it better than codecs.decode(..., "magic string") but certainly not enough to wrassle over it 💪
Member
Author
There was a problem hiding this comment.
I agree that the codecs approach isn't my favorite -- I'll make a note of this for when I give the tests a refresh 🤠
chlowell
approved these changes
Feb 9, 2021
This was referenced Feb 24, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #13561.
This updates EncryptionAlgorithms and KeyWrapAlgorithms to align with .NET, and adds a "7.2-preview" API version. Support for new algorithm inputs/outputs (
iv,authentication_tag, andadditional_authenticated_data) has been added, and tests have been adjusted to account for a lack of local encryption capabilities with new algorithms.