Skip to content

[Communication]: Fix replace keys for nested json#16557

Merged
sacheu merged 1 commit intoAzure:masterfrom
lsundaralingam:communication-identity-fix
Feb 5, 2021
Merged

[Communication]: Fix replace keys for nested json#16557
sacheu merged 1 commit intoAzure:masterfrom
lsundaralingam:communication-identity-fix

Conversation

@lsundaralingam
Copy link
Member

No description provided.

@ghost ghost added the Communication label Feb 5, 2021
@lsundaralingam
Copy link
Member Author

/azp run python - communication - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lsundaralingam lsundaralingam marked this pull request as ready for review February 5, 2021 03:29
@lsundaralingam lsundaralingam assigned sacheu and unassigned sacheu Feb 5, 2021

def _replace_keys(self, body):
def _replace_recursively(dictionary):
if type(dictionary) != dict:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if somehow using type instead of isinstance did something

Copy link

@sacheu sacheu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@sacheu sacheu merged commit a6a5074 into Azure:master Feb 5, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Feb 5, 2021
…into new_polling

* 'master' of https://github.com/Azure/azure-sdk-for-python: (250 commits)
  Converting to pure unit tests (Azure#16499)
  Fix replace keys for nested json (Azure#16557)
  update release date (Azure#16543)
  Feature/communication chat preview3 new model (Azure#16561)
  [text analytics] Exposed the length property in classes impacted by `string_index_type` (Azure#16538)
  [textanalytics] add :keyword: to docstrings for TextDocumentInput and DetectLanguageInput (Azure#16542)
  [SB] combine conn str parser logic in base handler and _common (Azure#16464)
  [text analytics] add analyze readme bullet point (Azure#16552)
  resolve issues with failing search documents on mindependency checks (Azure#16553)
  [text analytics] analyze changes (Azure#16418)
  [Core] Added enum meta class (Azure#16316)
  Adding missing supported fields to invoice sample (Azure#16547)
  Update EventHub ci.yml to skip unsupported pypy3 (Azure#16545)
  patching the publishing of artifacts only on successful run (Azure#16539)
  need to bump msrest up one (Azure#16544)
  [EventHub&ServiceBUs] Update readme pointing to uamqp installation guidance (added alpine installation) (Azure#16515)
  add dotenv as a dep for azure-sdk-tools (Azure#16532)
  skip prebuilt from_url tests for now (Azure#16534)
  Latest/Minimum filter retrieved packages by pyVersion compatibility (Azure#16510)
  CertificateCredential accepts certs as bytes (Azure#16410)
  ...
@lsundaralingam lsundaralingam changed the title Fix replace keys for nested json [Communication]: Fix replace keys for nested json Feb 8, 2021
@lsundaralingam lsundaralingam deleted the communication-identity-fix branch February 17, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants