Adding OpenTelemetry exporter code#14784
Merged
hectorhdzg merged 30 commits intoAzure:masterfrom Nov 11, 2020
Merged
Conversation
Contributor
|
Please rename the examples/ folder to samples/ |
Contributor
|
/azp run python - monitor - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run python - monitor - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run python - monitor - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hectorhdzg
requested review from
KieranBrantnerMagee,
RezaJooyandeh,
ankitarorabit,
annatisch,
changlong-liu,
chlowell,
danieljurek,
iscai-msft,
johanste,
jsntcy,
kristapratico,
mccoyp and
msyyc
as code owners
lzchen
reviewed
Nov 5, 2020
| # Release History | ||
|
|
||
| ## Unreleased | ||
| ## 1.0.0b1 (Unreleased) |
Member
There was a problem hiding this comment.
I believe this also doesn't follow semver? (open-telemetry/opentelemetry-python#1222 (comment))
Contributor
There was a problem hiding this comment.
We would release this package eventually as the first preview of the major version.
I've just updated it with the language precedent set. the python way to say 1.0.0-beta (a semantic guideline of semver) would be 1.0.0b1 (syntactic to python)
Contributor
There was a problem hiding this comment.
also, we currently adhere to semvers for all the GAed libraries- and for pre releases, we are compatible with pep 440 , https://www.python.org/dev/peps/pep-0440/#id27
Contributor
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rakshith91
previously approved these changes
Nov 6, 2020
lzchen
previously approved these changes
Nov 9, 2020
Movign clean up and setup code in tests
lzchen
approved these changes
Nov 11, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 14, 2020
…into new_polling * 'master' of https://github.com/Azure/azure-sdk-for-python: (281 commits) [Communication] Add variable groups necessary for using new azure subscription (Azure#15213) Sync eng/common directory with azure-sdk-tools for PR 1153 (Azure#15322) [Communication] Update version for Preview 3 release (Azure#15317) Increment package version after release of azure_data_tables (Azure#15291) [monitor] README + samples _ ci.yml (Azure#15288) refdoc aka.ms link was broken and silently redirecting, have replaced with azuresdkdocs link as is used in other SDKs. (Azure#15169) Sync eng/common directory with azure-sdk-tools for PR 1202 (Azure#15297) Updating OT exporter to consume latest version of OpenTelemetry API/SDK (Azure#15289) Change live test resource DeleteAfterHours tag to 8 hours (Azure#15294) Add Invoke-DevOpsAPI.ps1, Add functions for Canceling and Listing Builds (Azure#15013) The original one is removed. Point to the new one (Azure#15287) Sync eng/common directory with azure-sdk-tools for PR 1170 (Azure#15087) Adding OpenTelemetry exporter code (Azure#14784) update external link (Azure#15273) Remove invalid characters in basename sourced from username (Azure#15268) Sync eng/common directory with azure-sdk-tools for PR 1188 (Azure#15267) Increment version for core releases (Azure#15269) Increment package version after release of azure_identity (Azure#15266) Fix CI (Azure#15265) Increment package version after release of azure_eventgrid (Azure#15262) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving exporter code from https://github.com/microsoft/opentelemetry-azure-monitor-python
Updated code to use swagger generated data models and ApplicationInsights client
Adding tests and examples