ServiceBusAdministrationClient now uses _parse_conn_str from base_han…#14228
ServiceBusAdministrationClient now uses _parse_conn_str from base_han…#14228yunhaoling merged 4 commits intoAzure:masterfrom
Conversation
bradleydamato
requested review from
KieranBrantnerMagee,
annatisch and
yunhaoling
as code owners
ghost
added
Service Bus
customer-reported
|
Thank you for your contribution bradleydamato! We will review the pull request and get back to you soon. |
|
Hey @KieranBrantnerMagee did release get bumped to November or is that the next release? |
sdk/servicebus/azure-servicebus/azure/servicebus/management/_management_client.py
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/management/_management_client.py
Show resolved
Hide resolved
|
hey @bradleydamato, thanks for the PR! |
…) with _parse_conn_str() from base_handler
|
|
|
/azp run python - servicebus - tests |
|
No pipelines are associated with this pull request. |
|
@bradleydamato, thanks for addressing my comments, looks good to me. |
sdk/servicebus/azure-servicebus/azure/servicebus/aio/management/_management_client_async.py
Outdated
Show resolved
Hide resolved
new statement is: `from ..._base_handler import _parse_conn_str` Co-authored-by: Adam Ling (MSFT) <[email protected]>
A lot of these azure-pipeline checks ran when I first submitted the PR. Unsure if that is affecting them from running again. @yunhaoling for visibility. |
|
@bradleydamato, don't worry, I can take this. (I'll try some commands, please ignore them :P) |
|
/check-enforcer reset |
|
/check-enforcer evaluate |
|
/azp run python - servicebus - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@bradleydamato, PR looks good to me, all tests passed. |
|
Hey @yunhaoling thank you again for the thorough review! I would love to merge but it seems that I am not authorized to do so :/ |
|
@bradleydamato, sorry I don't know you can't do it, I'll raise it to our team. anyways, let me merge it for you. thanks! |
|
Thank you @yunhaoling !!! |
3 participants
…dlers
Hey @KieranBrantnerMagee @YijunXieMS I'm 90% sure that this passed all of the tests, here is a screenshot of both my invocation and the output post-test.
Also, let me know if I totally misunderstood you in terms of the changes to make!