Implement full vault backup and restore#13525
Merged
chlowell merged 5 commits intoAzure:masterfrom Sep 4, 2020
Merged
Conversation
iscai-msft
previously approved these changes
Sep 2, 2020
Contributor
There was a problem hiding this comment.
tiniest nit #
Suggested change
| """Restore a Key Vault backup. | |
| """Restore a full backup of a Key Vault |
christothes
previously approved these changes
Sep 2, 2020
Member
christothes
left a comment
There was a problem hiding this comment.
Looks good at the api level
1bae6ff
iscai-msft
previously approved these changes
Sep 4, 2020
Contributor
There was a problem hiding this comment.
don't think this typing would render properly
Member
Author
There was a problem hiding this comment.
Right you are. I copied it from the generated model. Fixing it depends on how we expose the error. I made this part of #13575.
mccoyp
reviewed
Sep 4, 2020
Member
There was a problem hiding this comment.
nit per the comment on the sync version
Suggested change
| """Restore a Key Vault backup. | |
| """Restore a full backup of a Key Vault. |
mccoyp
reviewed
Sep 4, 2020
Member
There was a problem hiding this comment.
Should this be the status of the restore operation?
mccoyp
reviewed
Sep 4, 2020
Member
There was a problem hiding this comment.
Same question about restore vs. backup operation
mccoyp
previously approved these changes
Sep 4, 2020
iscai-msft
approved these changes
Sep 4, 2020
mccoyp
approved these changes
Sep 4, 2020
xiafu-msft
added a commit
that referenced
this pull request
Sep 23, 2020
* Sync eng/common directory with azure-sdk-tools repository for Tools PR 916 (#13374) * Update Language Settings File (#13389) * [Storage]Revert equal sign in async (#13501) * Sync eng/common directory with azure-sdk-tools repository for Tools PR 930 (#13384) * fix authorization header on asyncio requests containing url-encoded chars (#13346) * fix authorization header on asyncio requests containing url-encoded-able characters (=, ! etc) * edit all authentication files and add a test Co-authored-by: xiafu <[email protected]> * If match headers (#13315) * verifying match conditions are correct, adding tests for other conditions * changes to verify etag is working, think it's being ignored by service * another change to test file, passing the correct etag to the service, it returns a 204 so no error is produced * renaming vars * testing for if-match conditions to make sure they are properly parsed and sent to service * reverting header back * testing update to reflect new response in create_entity * [text analytics] link opinion mining in the readme (#13493) * modify bing id docstring to mention Bing Entity Search more (#13509) * Tableitem metadata (#13445) * started collecting metadata, issue with asynciterator not being iterable * simplifying code, improving testing * issue with one recording, reran and seems good to go * fixing doc strings * fixed two tests, skipped another one. AsyncPageIterator is missing something to make it an iterator * new recording and skipping one test until can figure out AsyncPageIterator issue * adding asserts * add test for date and table_name, api_version is not returned unless full_metadata is specified * [EventGrid] Receive Functions (#13428) * initial changes * comments * str * static * from_json * Update sdk/eventgrid/azure-eventgrid/azure/eventgrid/_helpers.py * Fix storage file datalake readme and samples issues (#12512) * Fix storage file datalake readme issues * Update README.md * Make doc-owner recommended revisions to eventhub readme and samples. (#13518) Move auth samples into samples and link from readme rather than line. Add snippets to the top of samples lacking any verbiage. Whitespace improvements in client auth sample Explicit samples for connstr auth to link from new terse readme auth section. * [ServiceBus] Clean up README prior to P6 with doc-owner recommendations. (#13511) * Remove long-form samples from readme authentication section and move them into formal samples with URIs. (This by recommendation of docs folks, and supported via UX interview with user stating that the README was getting long in the teeth with this section being less critical) * Live pipeline issues (#13526) * changes to the tests that reflects the new serialization of EntityProperties, failing on acl payloads and sas signed identifiers * re-generated code, fixed a couple test methods, solved the media type issue for AccessPolicies, re-recorded tests because of changes in EntityProperty * updating a recording that slipped through * 404 python erroring sanitize_setup. should not be (#13532) * Sync eng/common directory with azure-sdk-tools repository for Tools PR 946 (#13533) * update release date for Sep (#13371) * update release date for Sep * fix typo * update release date for Sep (#13370) * update changelog (#13369) * [text analytics] add --pre suffix to pip install (#13523) * Change prerelease versioning (#13500) - Use a instead of dev - Fix dev to alpha for regression test - Clean-up some devops feed publishing steps * add test for opinion in diff sentence (#13524) * don't want to exclude mgmt. auto-increments are fine here (#13549) * [keyvault] fix include_pending param and 2016-10-01 compatibility (#13161) * Add redirect_uri argument to InteractiveBrowserCredential (#13480) * Sync eng/common directory with azure-sdk-tools for PR 955 (#13553) * Increment package version after release of azure_storage_file_datalake (#13111) * Increment package version after release of azure_storage_file_share (#13106) * Clean up "?" if there is no query in request URL (#13530) * cleaned up the ? in source urls * [devtool]turn primary_endpoint and key from unicode into str Co-authored-by: xiafu <[email protected]> * Update readme samples (#13486) * updated each sample to use env variables, more informative print statements * updating readme with more accurate links, still missing a few * grammar fixes * added a readme, and async versions for auth and create/delete operations * added more files (copies for async), and a README to the samples portion * basic commit, merging others into one branch * put async into another folder * more README updates to align with .NET * initial draft of README and samples * initial comments from cala and kate * caught a text analytics reference, thanks kate * caught a text analytics reference, thanks kate * reverting version * fixing two broken links * recording for test_list_tables that got left out * fixing broken links * another attempt at broken links * changing parentheses to a bracket per kristas recommendation * commenting out one test with weird behavior * found an actual broken link * lint fixes * update to readme and samples per cala, issy, and kates recs. added examples to sphinx docs that were not there. * added a quote around odata filter, thanks Chris for the catch * updating a few more broken links * adding an aka.ms link for pypi * two more broken links * reverting a change back * fixing missing END statements, removing link to nowhere, correcting logger * Sync eng/common directory with azure-sdk-tools repository for Tools PR 926 (#13368) * [keyvault] add scope enum (#13516) * delete connection_string in recorded tests (#13557) * Sync eng/common directory with azure-sdk-tools repository for Tools PR 823 (#13394) * Add sample docstrings to eg samples (#13572) * docstrings * Apply suggestions from code review * few more docstrings * decode * add licesnse * [EventGrid] README.md updates (#13517) * Fix a link which did not have a target * Use "Event Grid" instead of "Eventgrid" or "EventGrid" in prose * Cloud Event Abstraction (#13542) * initial commit * oops * some changes * lint * test fix * sas key * some more cahgnes * test fix * 2.7 compat * comments * extensions * changes * Update sdk/eventgrid/azure-eventgrid/azure/eventgrid/_models.py * remove test * Increment version for storage releases (#13096) * Increment package version after release of azure_storage_blob * Fix a docstring problem (#13579) * SharedTokenCacheCredential uses MSAL when given an AuthenticationRecord (#13490) * [EventHub] add SAS token auth capabilities to EventHub (#13354) * Add SAS token support to EventHub for connection string via 'sharedaccesssignature' * Adds changelog/docs/samples/tests, for now, utilize the old-style of test structure for sync vs async instead of preparer until import issue is resolved. * [Evengrid] Regenrate code gen (#13584) * Regenrate swagger * fix import * regen * Update Language Settings file (#13583) * Added blob exists method (#13221) * added feature and unit tests * fixed failing test issue * added async method and more unit tests * ffixed passed parameters * fixed python 27 issue with kwargs * reset commit * Update _blob_client_async.py removed unused import, fixed linter * Update sdk/storage/azure-storage-blob/azure/storage/blob/aio/_blob_client_async.py Co-authored-by: Xiaoxi Fu <[email protected]> * Update sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py Co-authored-by: Xiaoxi Fu <[email protected]> * fixed failing tests * fixed linting/import order Co-authored-by: Xiaoxi Fu <[email protected]> * [keyvault] administration package readme (#13489) * add release date to changelog (#13590) * Sync eng/common directory with azure-sdk-tools repository (#13589) * VisualStudioCodeCredential raises CredentialUnavailableError when configured for ADFS (#13556) * Implement full vault backup and restore (#13525) * Identity release notes (#13585) * [DataLake][Rename]Rename with Sas (#12057) * [DataLake][Rename]Rename with Sas * small fix * recordings * fix pylint * fix pylint * fix pylint * Update sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/_data_lake_directory_client_async.py * [Schema Registry + Avro Serializer] 1.0.0b1 (#13124) * init commit * avro serializer structure * adding avro serializer * tweak api version and fix a typo * test template * avro serializer sync draft * major azure sr client work done * add sample docstring for sr * avro serializer async impl * close the writer * update avro se/de impl * update avro serializer impl * fix apireview reported error in sr * srav namespace, setup update * doc update * update doc and api * impl, doc update * partial update according to laruent's feedback * be consistent with eh extension structure * more update code according to feedback * update credential config * rename package name to azure-schemaregistry-avroserializer * fix pylint * try ci fix * fix test for py27 as avro only accept unicode * first round of review feedback * remove temp ci experiment * init add conftest.py to pass py2.7 test * laurent feedback update * remove dictmixin for b1, update comment in sample * update api in avroserializer and update test and readme * update test, docs and links * add share requirement * update avro dependency * pr feedback and livetest update * Win py27 issue (#13595) * change to the processor to check for BOM at the beginning * changes to serialize and deserialize to be consistent with py2/3 strings/unicode types. new recordings for all that, changes to tests for everything, and a bug in sas file * forgot to add a unicode explicitly, re-recorded some tests because of that * Sync eng/common directory with azure-sdk-tools repository for Tools PR 969 (#13591) * [ServiceBus] Expose internal amqp message properties via AMQPMessage wrapper object on Message (#13564) * Expose internal amqp message properties via AMQPMessage wrapper object on Message. Add test, changelog notes and docstring. (Note: Cannot rename old message as uamqp relies on the internal property name. Should likely be adapted.) Co-authored-by: Adam Ling (MSFT) <[email protected]> * Update doc link in README.md (#13618) * Bump template version (#13580) * Increment package version after release of azure_appconfiguration (#13620) * Increment package version after release of azure_search_documents (#13622) * Increment package version after release of azure_core (#13621) * Fix data nspkg (#13623) * Add data nspkg to CI (#13626) * Update EH and SB code owner (#13633) * Rename ServiceBusManagementClient to ServiceBusAdministrationClient (#13597) * Rename ServiceBusManagementClient to ServiceBusAdministrationClient * Increment package version after release of azure_keyvault_certificates (#13630) * Add administration package to Key Vault pipeline (#13631) * fixed the long description, addition to changelog (#13637) * fixed the long description, addition to changelog * addresssing izzy's comments * [EventGrid] Fix lint errors (#13640) * Fix lint errors * comments * * Remove `is_anonymous_accessible` from management entities. (#13628) * Remove `support_ordering` from `create_queue` and `QueueProperties` * Remove `enable_subscription_partitioning` from `create_topic` and `TopicProperties` * update tests/changelog * Eventgrid Prepare for Release (#13643) * Release preparation * shared * codeowners * [Schema Registry] Fix docstring and docs (#13625) * fix docstring and docs * update codeowner and ci config * update init in serializer * update readme * update sr dependecy in avro serializer * update module __init__.py * revert dependcy to see if it helps doc generetion * [ServiceBus] Replace get_*_deadletter_receiver functions with a sub_queue parameter (#13552) * Remove get_*_deadletter_receiver functions and add a sub_queue parameter to get_*_receiver functions taking enum SubQueue to specify the target subqueue. Adjusts tests, docs accordingly. Co-authored-by: Adam Ling (MSFT) <[email protected]> * [Storage]Fix a permission bug and add enable test for list blob with metadata (#13260) * Fix permission bug * test list blobs with metadata * add snapshot to get_blob_properties() response * fix test * [ChangeFeed]Unify cursor and add live mode (#13243) * [ChangeFeed]Unify cursor and add live mode * make the token into a str * address comments * 1. add a while True for sample 2. make the list of shards in cursor to a dict in internal code 3. test list 3-shard events in multiple times generate same results as list all events at once 4. Java is using sequential list, so it could give 1 shard cursor even there are 3 shards, the test makes sure python is working with 1 shard cursor. * make end_time/start_time and continuation_token mutual exclusive * update dependency version * make all '' to "" in cursor * fix pylint and update changelog * fix blob pylint * added playback mode only marker (#13636) * Update changelog (#13641) * added changelogs * added prs/issues in the changelogs * Update CHANGELOG.md (#13657) * - Rename `entity_availability_status` to `availability_status` (#13629) - Make it unsettable in create_* mgmt operations. (as it is readonly) - adjust tests, docs etc. * init resourcemover ci (#13666) Co-authored-by: xichen <[email protected]> * Sdk automation/track2 azure mgmt keyvault (#13662) * Generated from c273efbfeb4c2c2e0729579114947c91ab747daa add tag * version and test Co-authored-by: SDK Automation <[email protected]> * Increment package version after release of azure_keyvault_administration (#13651) * Increment package version after release of azure_identity (#13652) * [SchemaRegistry] small fix in setup.py (#13677) * [SchemaRegistry] Pin avro serializer dependency version (#13649) * Increment package version after release of azure_data_tables (#13642) * Increment version for eventhub releases (#13644) * Increment package version after release of azure_eventhub * Increment package version after release of azure_eventhub_checkpointstoreblob * Increment package version after release of azure_eventhub_checkpointstoreblob_aio * Add parameters to function (#13653) * [ServiceBus] Consistency review changes as detailed in issue #12415. (#13160) * Consistency review changes as detailed in issue #12415. * significant amount of renames, parameter removal, mgmt shim class building, and a few added capabilities in terms of renew_lock retval and receive_deferred param acceptance. * Update mgmt test recordings Co-authored-by: Adam Ling (MSFT) <[email protected]> * [SchemaRegistry] Re-enable links check (#13689) * Release sdk resourcemover (#13665) * Generated from b7867a975ec9c797332d735ed8796474322c6621 fix schemas parameter * init ci and version Co-authored-by: SDK Automation <[email protected]> Co-authored-by: xichen <[email protected]> * [ServiceBus] Support SAS token-via-connection-string auth, and remove ServiceBusSharedKeyCredential export (#13627) - Remove public documentation and exports of ServiceBusSharedKeyCredential until we chose to release it across all languages. - Support for Sas Token connection strings (tests, etc) - Add safety net for if signature and key are both provided in connstr (inspired by .nets approach) Co-authored-by: Rakshith Bhyravabhotla <[email protected]> * [text analytics] default to v3.1-preview.2, have it listed under enum V3_1_PREVIEW (#13708) * Sync eng/common directory with azure-sdk-tools repository for Tools PR 982 (#13701) * Remove locale from docs links (#13672) * [ServiceBus] Set 7.0.0b6 release date in changelog (#13715) * [ServiceBus] Sample Fix (#13719) * fix samples * revert duration * Increment package version after release of azure_schemaregistry_avroserializer (#13682) * Increment package version after release of azure_schemaregistry (#13679) * Revert the changes of relative links (#13681) * KeyVaultBackupClient tests (#13709) * Release sdk automanage (
Closes #11975 by adding
KeyVaultBackupClient, which performs full vault backup and restore operations, and selective key restore operations. Also sets the package version to 4.0.0b1 (closes #13457).I'm opening this as a draft because I'm still working on tests. I have (passing!) tests locally but they rely on ugly workarounds for the difficulties of testing managed HSM and their recordings aren't yet safe to commit.