[text analytics] add output to opinion mining sample#13494
Merged
iscai-msft merged 1 commit intoAzure:masterfrom Sep 1, 2020
Merged
[text analytics] add output to opinion mining sample#13494iscai-msft merged 1 commit intoAzure:masterfrom
iscai-msft merged 1 commit intoAzure:masterfrom
Conversation
ghost
added
the
kristapratico
approved these changes
Sep 1, 2020
Contributor
kristapratico
left a comment
kristapratico
left a comment
There was a problem hiding this comment.
Still worried about output changing as model versions change, but I guess it's necessary to understand the concepts
Member
We could send the request with a specific model version and that way we know the output won't change. What do you think? |
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Sep 2, 2020
…into link_om_sample * 'master' of https://github.com/Azure/azure-sdk-for-python: (23 commits) Int32 serialization (Azure#13452) add output to opinion mining sample (Azure#13494) Add Document w/ Eng Sys Checks (Azure#13492) update version (Azure#13495) Remove resources post test (Azure#13379) bing_id -> bing_entity_search_api_id (Azure#13491) [EventGrid] Read me + improve docstrings (Azure#13484) Build AuthenticationRecords from ADFS identity tokens (Azure#13341) Support Subject Name/Issuer authentication (Azure#13350) Add KeyVaultAccessControlClient for data plane RBAC (Azure#13372) [text analytics] Add redacted_text (Azure#13449) add python sdk sample (Azure#13338) [text analytics] add versionadded sphinx documentation (Azure#13450) [text analytics] add bing_id property to LinkedEntity class (Azure#13446) fix typing for paging methods (Azure#13410) [text analytics] add domain_filter param (Azure#13451) fix issue Azure#11658 for is_valid_resource_id (Azure#11709) added create_table_if_not_exists method to table service client (Azure#13385) [ServiceBus] Test and failure improvements (Azure#13345) Proper encoding and decoding of source URLs - Fixes special characters in source URL issue (Azure#13275) ...
Contributor
Author
|
@maririos I think it's better to not add it because users might think that model version is more necessary than it is since we've included it in a sample. The output of this sample is also not super finnicky (i.e. i don't think it should change that much with diff model versions), since I'm only outputting the aspect and opinion text with the sentiment. But I def understand the concerns, I think I'll keep it without model version for now. If it becomes necessary in the future, I'll look into adding the model version |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Mar 30, 2021
datamigration readme t2 config (Azure#13494) * datamigration readme t2 config * datamigration readme change * datamigration readme change V2 * dataMigration readme change
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Mar 30, 2021
datamigration readme t2 config (Azure#13494) * datamigration readme t2 config * datamigration readme change * datamigration readme change V2 * dataMigration readme change
00Kai0
pushed a commit
that referenced
this pull request
Apr 7, 2021
* CodeGen from PR 13494 in Azure/azure-rest-api-specs datamigration readme t2 config (#13494) * datamigration readme t2 config * datamigration readme change * datamigration readme change V2 * dataMigration readme change * version,CHANGELOG * test * datamigration changelog config Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Zed Lei <[email protected]> Co-authored-by: Zed <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13120