Conversation
seankane-msft
added
Client
|
|
||
| _CONNECTION_ENDPOINTS_SECONDARY = {'table': 'TableSecondaryEndpoint', 'cosmos': 'TableSecondaryEndpoint'} | ||
|
|
||
| class StorageTableClientTest(TableTestCase): |
There was a problem hiding this comment.
nit: I think this could be an issue dealt with later, but would it be possible to split up the test files a little more? Maybe into ones using connection strings
…hould solve internal pipeline issue
| async def test_create_service_with_key_async(self, resource_group, location, storage_account, storage_account_key): | ||
| # Arrange | ||
|
|
||
| for client, url in SERVICES.items(): |
There was a problem hiding this comment.
can you check that these tests are actually running as expected? I see SERVICES commented out above so I don't think we're actually hitting any of these calls/asserts.
There was a problem hiding this comment.
You're correct, we are not hitting any of these.
There was a problem hiding this comment.
is that intentional?
|
@seankane-msft are you able to have a pipeline run when you add BuildTargetingString? |
…ect new changes in the client, will test for _primary_hostname in future PR
| self.assertIsInstance(tables, list) | ||
|
|
||
| # @pytest.mark.skip("pending") | ||
| @pytest.mark.skip("pending") |
There was a problem hiding this comment.
Is there a reason this one is skipped?
There was a problem hiding this comment.
No it is passing fine, I will uncomment it. Good catch!
{storage} Add new api version in readme (Azure#13034)
* add api
* refine
4 participants
Fixes #12999 adds more tests, adds recordings for new tests