[text analytics] generate multiapi client, made v3.1-preview.1 default version#12720
Merged
iscai-msft merged 4 commits intoAzure:masterfrom Jul 29, 2020
Merged
Conversation
iscai-msft
requested review from
johanste,
kristapratico,
lmazuel and
rakshith91
ghost
added
the
| :keyword int polling_interval: Default waiting time between two polls for LRO operations if no Retry-After header is present. | ||
| """ | ||
|
|
||
| DEFAULT_API_VERSION = 'v3.0' |
Contributor
There was a problem hiding this comment.
Based on the changelog blurb, should this be v3.1-preview.1?
Contributor
Author
There was a problem hiding this comment.
talked to @kristapratico about this offline. For the generated code I made default v3.0 to avoid syntaxerror's when calling the generated multiapi client, since v3.1-preview.1 added a parameter.
In the wrapped librnary, the default is v3.1-preview.1, meaning if a user doesn't pass in an api version, I pass v3.1-preview.1 to the generated multiapi client
| """ | ||
|
|
||
| DEFAULT_API_VERSION = 'v3.0' | ||
| _PROFILE_TAG = "azure.ai.textanalytics.TextAnalyticsClient" |
Contributor
There was a problem hiding this comment.
should this be "azure.ai.textanalytics.aio.TextAnalyticsClient"?
Contributor
Author
There was a problem hiding this comment.
good catch, have opened an autorest bug on it: Azure/autorest.python#730
Shouldn't block this PR though
| @@ -0,0 +1,117 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
do we check this file in for multiapi?
Contributor
Author
There was a problem hiding this comment.
The _metadata.json files are only used when creating the generated multiapi client, since they include the info that the multiapi client would need to know about each individual API. They have no use outside of that. We shouldn't remove them from the repo though, there's precedence (see mgmt plane network) for just keeping the files
| @@ -27,6 +27,6 @@ def test_v3_0_api_version(self, resource_group, location, text_analytics_account | |||
| @GlobalTextAnalyticsAccountPreparer() | |||
| def test_v3_1_preview_1_api_version(self, resource_group, location, text_analytics_account, text_analytics_account_key): | |||
| credential = AzureKeyCredential(text_analytics_account_key) | |||
| client = TextAnalyticsClient(text_analytics_account, credential, api_version=ApiVersion.V3_1_preview_1) | |||
| client = TextAnalyticsClient(text_analytics_account, credential, api_version=ApiVersion.V3_1_PREVIEW_1) | |||
Contributor
There was a problem hiding this comment.
should we also make a call to verify? or do we test that somewhere else...
Contributor
Author
There was a problem hiding this comment.
I think this is an adequate test. The generated client's base url contains v3.0 or v3.1-preview.1 depending on the , and we use the base url as the base for all of our function calls
Contributor
Author
|
/check-enforcer evaluate |
kristapratico
approved these changes
Jul 29, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jul 29, 2020
…into add_back_pii * 'master' of https://github.com/Azure/azure-sdk-for-python: (40 commits) [text analytics] generate multiapi client, made v3.1-preview.1 default version (Azure#12720) Prevent AttributeError during get_certificate_version (Azure#12747) re-apply updates after resetting master (Azure#12771) Sync eng/common directory with azure-sdk-tools repository (Azure#12745) Enable bandit for servicebus (Azure#12763) Skip pypy3 for service bus CI pipeline (Azure#12732) Update CODEOWNERS (Azure#12765) updated tox file (Azure#11087) Updating to match Microsoft recommended template (Azure#11045) [text analytics] update version in master (Azure#12749) Explicitly stringify message prints in samples per manual doc pass recommendation. (Azure#12709) Run only analyse dependency step for aggregate report (Azure#12728) VSCodeCredential supports Python 2.7 on Windows (Azure#12731) Enable bandit (Azure#12722) Move InteractiveCredential to a new module (Azure#12706) Add foundations for eng/common restructure (Azure#12725) Sync eng/common directory with azure-sdk-tools repository (Azure#12730) fix flaky test (Azure#12721) python link verification (Azure#12543) [ServiceBus] Remove legacy control client (Azure#12644) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jul 30, 2020
…into opinion_mining * 'master' of https://github.com/Azure/azure-sdk-for-python: (69 commits) [formrecognizer] renames from consistency check (Azure#12752) [text analytics] add back PII endpoint (Azure#12673) [text analytics] generate multiapi client, made v3.1-preview.1 default version (Azure#12720) Prevent AttributeError during get_certificate_version (Azure#12747) re-apply updates after resetting master (Azure#12771) Sync eng/common directory with azure-sdk-tools repository (Azure#12745) Enable bandit for servicebus (Azure#12763) Skip pypy3 for service bus CI pipeline (Azure#12732) Update CODEOWNERS (Azure#12765) updated tox file (Azure#11087) Updating to match Microsoft recommended template (Azure#11045) [text analytics] update version in master (Azure#12749) Explicitly stringify message prints in samples per manual doc pass recommendation. (Azure#12709) Run only analyse dependency step for aggregate report (Azure#12728) VSCodeCredential supports Python 2.7 on Windows (Azure#12731) Enable bandit (Azure#12722) Move InteractiveCredential to a new module (Azure#12706) Add foundations for eng/common restructure (Azure#12725) Sync eng/common directory with azure-sdk-tools repository (Azure#12730) fix flaky test (Azure#12721) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jul 30, 2020
…into regenerate_secrets * 'master' of https://github.com/Azure/azure-sdk-for-python: (52 commits) [key vault] Regenerate keys (Azure#12101) [Tables] Azure Data Tables SDK, sync and async code (Azure#12766) fix doc, sample, docstring (Azure#12784) clean up links for PII samples (Azure#12826) [formrecognizer] renames from consistency check (Azure#12752) [text analytics] add back PII endpoint (Azure#12673) [text analytics] generate multiapi client, made v3.1-preview.1 default version (Azure#12720) Prevent AttributeError during get_certificate_version (Azure#12747) re-apply updates after resetting master (Azure#12771) Sync eng/common directory with azure-sdk-tools repository (Azure#12745) Enable bandit for servicebus (Azure#12763) Skip pypy3 for service bus CI pipeline (Azure#12732) Update CODEOWNERS (Azure#12765) updated tox file (Azure#11087) Updating to match Microsoft recommended template (Azure#11045) [text analytics] update version in master (Azure#12749) Explicitly stringify message prints in samples per manual doc pass recommendation. (Azure#12709) Run only analyse dependency step for aggregate report (Azure#12728) VSCodeCredential supports Python 2.7 on Windows (Azure#12731) Enable bandit (Azure#12722) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jul 30, 2020
…into regenerate_certs * 'master' of https://github.com/Azure/azure-sdk-for-python: [key vault] Regenerate keys (Azure#12101) [Tables] Azure Data Tables SDK, sync and async code (Azure#12766) fix doc, sample, docstring (Azure#12784) clean up links for PII samples (Azure#12826) [formrecognizer] renames from consistency check (Azure#12752) [text analytics] add back PII endpoint (Azure#12673) [text analytics] generate multiapi client, made v3.1-preview.1 default version (Azure#12720)
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jul 31, 2020
…into ta_opinion_mining_sample * 'master' of https://github.com/Azure/azure-sdk-for-python: (47 commits) [text analytics] opinion mining support (Azure#12542) [key vault] Regenerate keys (Azure#12101) [Tables] Azure Data Tables SDK, sync and async code (Azure#12766) fix doc, sample, docstring (Azure#12784) clean up links for PII samples (Azure#12826) [formrecognizer] renames from consistency check (Azure#12752) [text analytics] add back PII endpoint (Azure#12673) [text analytics] generate multiapi client, made v3.1-preview.1 default version (Azure#12720) Prevent AttributeError during get_certificate_version (Azure#12747) re-apply updates after resetting master (Azure#12771) Sync eng/common directory with azure-sdk-tools repository (Azure#12745) Enable bandit for servicebus (Azure#12763) Skip pypy3 for service bus CI pipeline (Azure#12732) Update CODEOWNERS (Azure#12765) updated tox file (Azure#11087) Updating to match Microsoft recommended template (Azure#11045) [text analytics] update version in master (Azure#12749) Explicitly stringify message prints in samples per manual doc pass recommendation. (Azure#12709) Run only analyse dependency step for aggregate report (Azure#12728) VSCodeCredential supports Python 2.7 on Windows (Azure#12731) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.