Skip to content

clean up resources / fix changelog (#12432)#12459

Merged
changlong-liu merged 2 commits intoAzure:release/v3from
changlong-liu:20200709-pipeline-template
Jul 15, 2020
Merged

clean up resources / fix changelog (#12432)#12459
changlong-liu merged 2 commits intoAzure:release/v3from
changlong-liu:20200709-pipeline-template

Conversation

@changlong-liu
Copy link
Member

No description provided.

@weshaggard
Copy link
Member

FYI @chidozieononiwu

@weshaggard
Copy link
Member

Can you please cherry-pick all the changes from #12432.

Copy link
Member

@chidozieononiwu chidozieononiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes will resolve the said error.

@weshaggard
Copy link
Member

These changes will resolve the said error.

Yes they will resolve it but I'd like to also get the resource reference changes from #12432 included and ported into this branch as well.

@changlong-liu
Copy link
Member Author

Hi @weshaggard , this PR is actually a cherry pick from #12432 .
But they are a little different because:

  1. the deleted contents in archetype-sdk-client.yml and cosmos-sdk-client.yml are not existed in release/v3 branch. They are added into master after release/v3's lastest rebase.
  2. a minor difference in CHANGELOG.md of containerregistry: looks like this is not related to this PR's topic :)

@weshaggard
Copy link
Member

@changlong-liu OK thanks for the update I now understand why they aren't part of this PR, and I'm OK with this change as is.

@chidozieononiwu can you please take a workitem to go and remove the resource references from all the other yml files in the release/v3 branch? I want to be sure that we don't accidently break anything else in this branch because of those.

@scbedd @praveenkuttappan any ideas why the pylint is failing in CI currently?

@praveenkuttappan
Copy link
Member

/azp run python - core -ci

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@praveenkuttappan
Copy link
Member

/azp run python - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@changlong-liu
Copy link
Member Author

Hi @praveenkuttappan @weshaggard , I cherry-picked lint fix for azure-core in last commit.

And the current formrecognizer issue should has no relation with mgmt release, shall I merge this PR now?

@praveenkuttappan
Copy link
Member

@kristapratico Can you please help us on this mypy failure for form recognizer? It's on release/v3 branch.

@kristapratico
Copy link
Contributor

@kristapratico Can you please help us on this mypy failure for form recognizer? It's on release/v3 branch.

#12514

@kristapratico
Copy link
Contributor

/azp run python - formrecognizer - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikenass51
Copy link

I recieved this note.

@changlong-liu
Copy link
Member Author

Thank you, @praveenkuttappan @kristapratico @mikenass51 .
It's all green now.

@changlong-liu changlong-liu merged commit bdfb3a2 into Azure:release/v3 Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants