Merged
Conversation
Member
Author
Member
Author
|
Remove DataSourceCredentials |
Member
Author
|
rename SearchIndexerDataSource to SearchIndexerDataSourceConnection |
rakshith91
reviewed
May 22, 2020
| 'description': {'key': 'description', 'type': 'str'}, | ||
| 'type': {'key': 'type', 'type': 'str'}, | ||
| 'connection_string': {'key': 'connectionString', 'type': 'str'}, | ||
| 'container': {'key': 'container', 'type': 'SearchIndexerDataContainer'}, |
Contributor
There was a problem hiding this comment.
should this be "flattenned" too like the connection string? perhaps just take in a container name + kwargs and create the DataContainer ourselves? Just a possible suggestion - no strong opinion
rakshith91
reviewed
May 22, 2020
| @distributed_trace | ||
| def create_or_update_datasource(self, data_source, name=None, **kwargs): | ||
| # type: (SearchIndexerDataSource, Optional[str], **Any) -> Dict[str, Any] | ||
| # type: (SearchIndexerDataSourceConnection, Optional[str], **Any) -> SearchIndexerDataSourceConnection |
Contributor
There was a problem hiding this comment.
We should do this in a different PR prolly - but we must allow individual keywords only to update the datasource - which if present would override the datasource. (See skillsets for example)
rakshith91
approved these changes
May 22, 2020
iscai-msft
added a commit
that referenced
this pull request
May 26, 2020
…into feature/text_analytics_v3.0 * 'master' of https://github.com/Azure/azure-sdk-for-python: Release azure mgmt containerregistry (#11460) Prepare core 1.6.0 on master (#11610) Add force parameter to SwaggerToSdk CLI (#11609) LRO continuation_token (#10801) Remove unecessary import (#11606) Fix Cleanup failing on 3.8.3 (#11607) remove DataSourceCredentials (#11605) Search synonym map (#11590) Fix copy tests (#11594) Make use_training_labels positional required (#11529) Search refactoring 2 (#11584) Search refactoring 1 (#11572)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.