Add user authentication API to UsernamePasswordCredential#11528
Merged
chlowell merged 4 commits intoAzure:masterfrom May 20, 2020
Merged
Add user authentication API to UsernamePasswordCredential#11528chlowell merged 4 commits intoAzure:masterfrom
chlowell merged 4 commits intoAzure:masterfrom
Conversation
chlowell
added
Client
chlowell
force-pushed
the
user-pass-authrecord
branch
from
18264c9 to
deb4f74
Compare
xiangyan99
reviewed
May 19, 2020
| # first time it's asked for a token. However, we want to ensure this first authentication is not silent, to | ||
| # validate the given password. This class therefore doesn't document the authentication_record argument, and we | ||
| # discard it here. | ||
| kwargs.pop("authentication_record", None) |
Member
There was a problem hiding this comment.
In old code, I see
for account in accounts:
result = app.acquire_token_silent(scopes, account=account)
if result:
break
It seems to me we allow first time silent authentication?
Member
Author
There was a problem hiding this comment.
It may appear so but that was actually impossible because the cache was in memory; the credential always started with an empty one.
xiangyan99
reviewed
May 19, 2020
xiangyan99
approved these changes
May 20, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
May 21, 2020
…into make_canary_test * 'master' of https://github.com/Azure/azure-sdk-for-python: (28 commits) Kaihuis maps (Azure#11574) [formrecognizer] support Copy API (Azure#11372) Artifact Powered Docs.MS Release (Azure#11395) Sync eng/common directory with azure-sdk-tools repository (Azure#11562) Updated changelog (Azure#11554) update pinned versions in autorest_req.txt (Azure#11557) Add user authentication API to UsernamePasswordCredential (Azure#11528) Reduce Build Matrix (Azure#11539) Prevent Key Vault test failure due to operation timing (Azure#11552) update tests (Azure#11534) Datashare 2019 11 01 (Azure#11540) Search Renames / Regen (Azure#11342) update unit test according to the latest uamqp update (Azure#11533) Sync eng/common directory with azure-sdk-tools repository (Azure#11472) rename input parameters (Azure#11518) [cosmos] readme review feedback (Azure#11527) Update CODEOWNERS (Azure#11516) [Core] Support multipart changesets (Azure#10972) fix AttributeException (Azure#11463) release-for-hanaonazure-mgmt (Azure#11441) ...
iscai-msft
added a commit
that referenced
this pull request
May 21, 2020
…into feature/text_analytics_v3.0 * 'master' of https://github.com/Azure/azure-sdk-for-python: (28 commits) Kaihuis maps (#11574) [formrecognizer] support Copy API (#11372) Artifact Powered Docs.MS Release (#11395) Sync eng/common directory with azure-sdk-tools repository (#11562) Updated changelog (#11554) update pinned versions in autorest_req.txt (#11557) Add user authentication API to UsernamePasswordCredential (#11528) Reduce Build Matrix (#11539) Prevent Key Vault test failure due to operation timing (#11552) update tests (#11534) Datashare 2019 11 01 (#11540) Search Renames / Regen (#11342) update unit test according to the latest uamqp update (#11533) Sync eng/common directory with azure-sdk-tools repository (#11472) rename input parameters (#11518) [cosmos] readme review feedback (#11527) Update CODEOWNERS (#11516) [Core] Support multipart changesets (#10972) fix AttributeException (#11463) release-for-hanaonazure-mgmt (#11441) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11449