[text analytics] Update ta tests#11461
Merged
iscai-msft merged 12 commits intoAzure:masterfrom May 18, 2020
Merged
Conversation
…etect_language tests
iscai-msft
requested review from
kinelski,
kristapratico,
maririos,
mssfang,
rakshith91,
samvaity and
willmtemple
maririos
previously approved these changes
May 15, 2020
Member
|
I'm curious... was this driven by looking at the tests other languages have? |
sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_request_handlers.py
Outdated
Show resolved
Hide resolved
sdk/textanalytics/azure-ai-textanalytics/tests/test_analyze_sentiment.py
Show resolved
Hide resolved
Contributor
Author
yep, for the most part! |
kristapratico
approved these changes
May 15, 2020
iscai-msft
added a commit
that referenced
this pull request
May 18, 2020
…into feature/text_analytics_v3.0 * 'master' of https://github.com/Azure/azure-sdk-for-python: [text analytics] Update ta tests (#11461) Release azure mgmt hybridkubernetes (#11483) add ci to azure-mgmt-eventhub (#11459) [Service Bus] Enable pylint and mypy (#11316) update CODEOWNERS with smoke test owners (#11404) Sync eng/common directory with azure-sdk-tools repository (#11469)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11442
definitely recommend looking commit by commit since they're independent of each other