Smoke Tests use new workflow for package install#11438
Merged
danieljurek merged 10 commits intomasterfrom May 15, 2020
Merged
Conversation
…olving dependencies
danieljurek
requested review from
mitchdenny,
scbedd and
weshaggard
as code owners
Member
Author
|
/azp run python - smoke-tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scbedd
approved these changes
May 14, 2020
Member
scbedd
left a comment
scbedd
left a comment
There was a problem hiding this comment.
LGTM. I can't see any interaction that will break. Easiest way to to tell this is to wait for this build to succeed.
iscai-msft
added a commit
that referenced
this pull request
May 18, 2020
…into feature/text_analytics_v3.0 * 'master' of https://github.com/Azure/azure-sdk-for-python: (128 commits) add more content to index crud samples (#11443) Add a snippet to the Samples readme mirroring the core readme, guiding users to the currently mainline version of the lib if the end up on the wrong page. (#11420) 20200515 run resource live test (#11454) Release azure mgmt eventgrid (#11431) Smoke Tests use new workflow for package install (#11438) ServiceFabric 7.1 (#11451) update (#11424) Typing for appconfiguration (#11427) [form recognizer] Move `get_client` method from FormRecognizer -> FormTraining (#11423) release customvision (#11428) Enforce https in search (#11337) [Cosmos] Remove unused files (#11388) Sync eng/common directory with azure-sdk-tools repository (#11417) [form recognizer] consistency renames for FormTrainingClient (#11390) Release for azure mgmt eventhub (#11403) Network 2020 04 01 (#11405) link in to reference docs for sub-clients (#11396) Persistent caching for interactive credentials on Linux and macOS (#11319) [formrecognizer] add AAD auth support (#11275) Search docs/readme updates (#11391) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: #11436
Fix workflow:
requirements.txtpackages from the dev feed by install no dependencies (e.g.--no-deps)requirements_dependencies.txtrequirements_dependencies.txtSuccessful execution: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=392226&view=results
Couple decisions here:
dependencies.pyand ininstall_dev_build_dependnecy.pyand so I think all of therequirements.txtwork should be removed fromisntall_dev_build_dependency.py... This workflow also differs from the tox preparation steps more than the previous implementation.dependencies.pybut that is not readily available to other scenarios. Should it be more available?