[Cosmos] Remove unused files#11388
Merged
southpolesteve merged 2 commits intoAzure:masterfrom May 13, 2020
Merged
Conversation
Contributor
southpolesteve
commented
May 12, 2020
southpolesteve
commented
- Remove unused murmur hash and consistent hashing ring files
- Run local tests against proper emulator port
southpolesteve
commented
May 12, 2020
| #[SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Cosmos DB Emulator Key")] | ||
| masterKey = os.getenv('ACCOUNT_KEY', 'C2y6yDjf5/R+ob0N8A7Cgv30VRDJIWEHLM+4QDU5DE2nQ9nDuVTqobD4b8mGGyPMbIZnqyMsEcaGQy67XIw/Jw==') | ||
| host = os.getenv('ACCOUNT_HOST', 'https://localhost:443/') | ||
| host = os.getenv('ACCOUNT_HOST', 'https://localhost:8081/') |
Contributor
Author
There was a problem hiding this comment.
The internal emulator uses 443. This change runs the tests against the public emulator on 8081
southpolesteve
commented
May 12, 2020
| replaced_document['id'], | ||
| replaced_document['id']) | ||
|
|
||
| def test_murmur_hash(self): |
Contributor
Author
There was a problem hiding this comment.
This code is tested but does not appear to be used in any application code
Member
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@annatisch What's the difference between the tests that ran when I opened the PR and the ones that ran when you triggered the pipeline via the bot? |
Member
|
@southpolesteve - it should be live vs emulator. |
Member
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
approved these changes
May 13, 2020
Member
annatisch
left a comment
annatisch
left a comment
There was a problem hiding this comment.
Thanks for this! Love removing code.... :)
iscai-msft
added a commit
that referenced
this pull request
May 13, 2020
…into move_get_client_for * 'master' of https://github.com/Azure/azure-sdk-for-python: [Cosmos] Remove unused files (#11388) Sync eng/common directory with azure-sdk-tools repository (#11417) [form recognizer] consistency renames for FormTrainingClient (#11390) Release for azure mgmt eventhub (#11403) Network 2020 04 01 (#11405) link in to reference docs for sub-clients (#11396) Persistent caching for interactive credentials on Linux and macOS (#11319) [formrecognizer] add AAD auth support (#11275) Search docs/readme updates (#11391) Sync eng/common directory with azure-sdk-tools repository (#11387) Update tests for msal 1.3.0 (#11307)
iscai-msft
added a commit
that referenced
this pull request
May 18, 2020
…into feature/text_analytics_v3.0 * 'master' of https://github.com/Azure/azure-sdk-for-python: (128 commits) add more content to index crud samples (#11443) Add a snippet to the Samples readme mirroring the core readme, guiding users to the currently mainline version of the lib if the end up on the wrong page. (#11420) 20200515 run resource live test (#11454) Release azure mgmt eventgrid (#11431) Smoke Tests use new workflow for package install (#11438) ServiceFabric 7.1 (#11451) update (#11424) Typing for appconfiguration (#11427) [form recognizer] Move `get_client` method from FormRecognizer -> FormTraining (#11423) release customvision (#11428) Enforce https in search (#11337) [Cosmos] Remove unused files (#11388) Sync eng/common directory with azure-sdk-tools repository (#11417) [form recognizer] consistency renames for FormTrainingClient (#11390) Release for azure mgmt eventhub (#11403) Network 2020 04 01 (#11405) link in to reference docs for sub-clients (#11396) Persistent caching for interactive credentials on Linux and macOS (#11319) [formrecognizer] add AAD auth support (#11275) Search docs/readme updates (#11391) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.