Persistent caching for interactive credentials on Linux and macOS#11319
Merged
chlowell merged 8 commits intoAzure:masterfrom May 12, 2020
Merged
Persistent caching for interactive credentials on Linux and macOS#11319chlowell merged 8 commits intoAzure:masterfrom
chlowell merged 8 commits intoAzure:masterfrom
Conversation
chlowell
added
Client
xiangyan99
reviewed
May 7, 2020
| if not self._cache: | ||
| if kwargs.pop("enable_persistent_cache", False): | ||
| self._cache = _load_persistent_cache() | ||
| allow_unencrypted = kwargs.pop("allow_unencrypted_cache", False) |
Member
There was a problem hiding this comment.
Is this a public kwarg?
I don't see it in docstring.
Member
Author
There was a problem hiding this comment.
Yes. Check the diffs for browser.py and device_code.py.
Member
There was a problem hiding this comment.
Do you mean users are not supposed to use MsalCredential directly?
xiangyan99
reviewed
May 12, 2020
| ) | ||
| persistence = msal_extensions.FilePersistence(file_path) | ||
| else: | ||
| raise NotImplementedError("A persistent cache is not available on this platform.") |
Member
There was a problem hiding this comment.
Do you think we should give more accurate error message if it is used on windows by "LOCALAPPDATA" is not set?
Member
Author
There was a problem hiding this comment.
What do you have in mind for a more accurate message? Something like "Environment variable LOCALAPPDATA isn't set"?
Member
There was a problem hiding this comment.
Yes. If I see "A persistent cache is not available on this platform" on windows, I will feel very confused. :)
Member
Author
There was a problem hiding this comment.
I agree with you there. I'm content with simply saying the cache is unavailable in this case but I think saying it's unavailable on this platform is misleading. I changed the message to say the cache is unavailable in this environment instead.
xiangyan99
previously approved these changes
May 12, 2020
xiangyan99
approved these changes
May 12, 2020
iscai-msft
added a commit
that referenced
this pull request
May 13, 2020
…into move_get_client_for * 'master' of https://github.com/Azure/azure-sdk-for-python: [Cosmos] Remove unused files (#11388) Sync eng/common directory with azure-sdk-tools repository (#11417) [form recognizer] consistency renames for FormTrainingClient (#11390) Release for azure mgmt eventhub (#11403) Network 2020 04 01 (#11405) link in to reference docs for sub-clients (#11396) Persistent caching for interactive credentials on Linux and macOS (#11319) [formrecognizer] add AAD auth support (#11275) Search docs/readme updates (#11391) Sync eng/common directory with azure-sdk-tools repository (#11387) Update tests for msal 1.3.0 (#11307)
iscai-msft
added a commit
that referenced
this pull request
May 18, 2020
…into feature/text_analytics_v3.0 * 'master' of https://github.com/Azure/azure-sdk-for-python: (128 commits) add more content to index crud samples (#11443) Add a snippet to the Samples readme mirroring the core readme, guiding users to the currently mainline version of the lib if the end up on the wrong page. (#11420) 20200515 run resource live test (#11454) Release azure mgmt eventgrid (#11431) Smoke Tests use new workflow for package install (#11438) ServiceFabric 7.1 (#11451) update (#11424) Typing for appconfiguration (#11427) [form recognizer] Move `get_client` method from FormRecognizer -> FormTraining (#11423) release customvision (#11428) Enforce https in search (#11337) [Cosmos] Remove unused files (#11388) Sync eng/common directory with azure-sdk-tools repository (#11417) [form recognizer] consistency renames for FormTrainingClient (#11390) Release for azure mgmt eventhub (#11403) Network 2020 04 01 (#11405) link in to reference docs for sub-clients (#11396) Persistent caching for interactive credentials on Linux and macOS (#11319) [formrecognizer] add AAD auth support (#11275) Search docs/readme updates (#11391) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adopts msal-extensions 0.2.2 to enable persistent token caching on Linux and macOS for
DeviceCodeCredentialandInteractiveBrowserCredential. It also adds a new keyword argument for those credentials,allow_unencrypted_cache, which determines whether to fall back to a plaintext cache on Linux when libsecret or PyGObject are unavailable (defaultsFalse).Strings and paths for the new platforms are from Azure/azure-sdk-for-java#9188 and the default behavior of MSAL's Java extension library.