Blob versioning#11154
Merged
xiafu-msft merged 5 commits intoAzure:feature/storage-stg73from Jun 10, 2020
Merged
Conversation
xiafu-msft
force-pushed
the
feature/storage-stg73
branch
from
c8b24fe to
8f45e1a
Compare
xiafu-msft
force-pushed
the
feature/storage-stg73
branch
from
8f45e1a to
d08d639
Compare
xiafu-msft
force-pushed
the
blob-versioning
branch
from
cc69d60 to
d73da47
Compare
xiafu-msft
force-pushed
the
blob-versioning
branch
from
d73da47 to
6d138df
Compare
xiafu-msft
requested review from
amishra-dev,
annatisch,
rakshith91 and
zezha-msft
as code owners
annatisch
requested changes
May 14, 2020
sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py
Outdated
Show resolved
Hide resolved
| :keyword str version_id: | ||
| The version id parameter is an opaque DateTime | ||
| value that, when present, specifies the version of the blob to delete. | ||
| It for service version 2019-10-10 and newer. |
Member
There was a problem hiding this comment.
"Introduced in service version 2019-10-10"
Also add the docstring tag for new parameters in the SDK.
| raise ValueError("The delete_snapshots option cannot be used with a specific snapshot.") | ||
| options = self._generic_delete_blob_options(delete_snapshots, **kwargs) | ||
| options['snapshot'] = self.snapshot | ||
| options['version_id'] = kwargs.pop('version_id', None) or self.version_id |
Member
There was a problem hiding this comment.
If we're also supporting version override for download and delete we should add to the docstring :)
Contributor
Author
There was a problem hiding this comment.
good catch, I missed the docstr.
How do you feel about this kwargs.pop('version_id', None) or self.version_id, do you feel redundant or it's fine?
Contributor
Author
There was a problem hiding this comment.
discussed offline, remove self.version_id
| :param bool delete: | ||
| Delete the blob. | ||
| :param bool delete_version: | ||
| Delete the blob version for the versioning enabled storage account. |
Member
There was a problem hiding this comment.
I'm confused by this.... does it mean we are giving permission to delete non-current blob versions? Or any blob in a version-enabled-account?
Contributor
Author
There was a problem hiding this comment.
Yes, it's to give permission to delete the non-current(past) versions
Member
There was a problem hiding this comment.
Then I think we should rename this... maybe delete_previous_versions or something...
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/models.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_shared_access_signature.py
Outdated
Show resolved
Hide resolved
annatisch
added
APIChange
xiafu-msft
added a commit
that referenced
this pull request
Jun 10, 2020
xiafu-msft
added a commit
that referenced
this pull request
Jul 7, 2020
* [Storage]STG73 * [Blob][Swagger]Update Swagger (#10943) * [Blob][Swagger]Regenerate Swagger Code * fix container test failure caused by list_containers include type change * [Storage] Internal avro parser. (#10764) * initial avro parser * try fixing test... * falling in love with python compatibility... * make linter happy. * raise StopIteration when there is no more bytes instead of tracking file length. * async avro parser * fix syntax for Python 3.5 * get rid of 'readers_schema' as we only honor schema that has been written to file ('writer_schema'). * pr feedback * trim unused code. * pr feedback. * simplify skip sync in next. * move avro tests from _shared. * Jumbo blob support (#11176) * wip * initial test coverage. * wip. * wip * single upload. * add async tests. * disable 50k block tests. * datalake append. * async datalake * disable tests that send large payload over network. * pr feedback. * Undelete share (#11394) * Undelete container (#11339) * [Storage][Blob] Added support for Object Replication (#11525) * Blob versioning (#11154) * [Blob][QuickQuery]Add Quick Query Support (#10946) * [Blob][STG73]Blob Tags (#11418) * regenerate code (#11964) * fix the bug which caused only showing fatal error (#11997) * [Storage][STG73]Address API Review Comments (#12111) * [Storage][STG73]Address API Review Comments * [Storage][STG73]dict<policy, rules> -> list(ObjectReplicationPolicy) * fix blob tag_value test * expose ObjectReplicationPolicy and ObjectReplicationRule, fix test * fix test * Changefeed (#10755) * [ChangeFeed]Add ChangeFeed Package * test_avro failure * update dev_requirement.txt * change namespace to azure.storage.blob.changefeed * address comments * optimize memory when reading changefeed events * namespace change * set up package change * fix failed tests * readme and kwargs * Update sdk/storage/azure-storage-blob-changefeed/azure/storage/blob/changefeed/_change_feed_client.py Co-authored-by: Rakshith Bhyravabhotla <[email protected]> * address comments * 'azure-storage-blob>=12.3.0' which does not match the frozen requirement 'azure-storage-blob~=1.3' Co-authored-by: Rakshith Bhyravabhotla <[email protected]> * [Storage-Blob] Quick Query API (#11991) * Renamed query error * Renamed query reader * Updated config models * Updated format request params * Updated iterator * fix the bug which caused only showing fatal error * Updated Error message * Fixed query helper * Started test conversion * small fix * Fixed tests * Updated error handling + json model * Updated recordings * Removed old recording * Added iter tests * Iter test recordings * Fix test * Remove extra recording * Fix pylint * Some docs cleanup * Renamed iter_records -> iter_stream * Review feedback * Updated tests * Missing commas * Fix syntax * Fix pylint Co-authored-by: xiafu <[email protected]> * tag sas (#12258) * tag sas * disable undelete_container * pylint * skip undelete_container tests * [Blob][Versioning]Disable Versioning Live Test (#12281) * [Blob][QQ]Default output_format to input_format (#12283) * [Storage][Jumbo]Remove super (#12314) * [Storage][JumboBlob]remove empty super() * pypy3 * change sas version to latest * set tags account location to central canada * re-recording queue * changefeed paths generator * mark tests for vid as playback only * fix changefeed * fix pylint make the test account location for tags to central canada * add a delay before calling find_blobs_by_tags * remove tags header * mark a large file test playback only * revert "mark a large file test playback only" skip upload large file test address comment * move tag permission and filter_by_tags permission to kwargs Co-authored-by: Kamil Sobol <[email protected]> Co-authored-by: Ze Qian Zhang <[email protected]> Co-authored-by: Rakshith Bhyravabhotla <[email protected]> Co-authored-by: annatisch <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.