Conversation
This was referenced Apr 10, 2020
annatisch
reviewed
Apr 20, 2020
annatisch
reviewed
Apr 20, 2020
Contributor
|
Possible to add some unit tests? |
lmazuel
force-pushed
the
lro_continuation_token
branch
from
c5771b0 to
c4420ec
Compare
annatisch
reviewed
May 21, 2020
annatisch
reviewed
May 21, 2020
annatisch
reviewed
May 21, 2020
| :returns: The current status string | ||
| :rtype: str | ||
| """ | ||
| return self._polling_method.status() |
Member
There was a problem hiding this comment.
Not necessary for this PR - but it would be good if we could open up the contract regarding the expected return type status in future.
Member
There was a problem hiding this comment.
I've started creating an azure-core-typing package multiple times that would include all the protocols that we have (LRO, item paged, page paged etc.). I will take another stab at it as part of the next round of azure client library python design guideline updates.
annatisch
previously approved these changes
May 21, 2020
iscai-msft
added a commit
that referenced
this pull request
May 26, 2020
…into feature/text_analytics_v3.0 * 'master' of https://github.com/Azure/azure-sdk-for-python: Release azure mgmt containerregistry (#11460) Prepare core 1.6.0 on master (#11610) Add force parameter to SwaggerToSdk CLI (#11609) LRO continuation_token (#10801) Remove unecessary import (#11606) Fix Cleanup failing on 3.8.3 (#11607) remove DataSourceCredentials (#11605) Search synonym map (#11590) Fix copy tests (#11594) Make use_training_labels positional required (#11529) Search refactoring 2 (#11584) Search refactoring 1 (#11572)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also Azure/autorest.python#565