Conversation
|
Is this the entire Change Feed implementation? |
It's not! Only a draft pr! |
5b9faa8 to
f74956f
Compare
sdk/storage/azure-storage-blob-changefeed/azure/storage/blobchangefeed/__init__.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob-changefeed/azure/storage/blobchangefeed/_change_feed_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob-changefeed/azure/storage/blobchangefeed/_change_feed_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob-changefeed/azure/storage/blobchangefeed/_models.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This could be moved out of the class into a utility function?
d181575 to
0fa4243
Compare
c8b24fe to
8f45e1a
Compare
8f45e1a to
d08d639
Compare
sdk/storage/azure-storage-blob-changefeed/azure/storage/blobchangefeed/_deserialize.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob-changefeed/azure/storage/blobchangefeed/_models.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob-changefeed/azure/storage/blobchangefeed/_models.py
Show resolved
Hide resolved
sdk/storage/azure-storage-blob-changefeed/azure/storage/blobchangefeed/_models.py
Outdated
Show resolved
Hide resolved
a4f697b to
60ada0b
Compare
| @@ -0,0 +1,6 @@ | |||
| include *.md | |||
| include azure/__init__.py | |||
| include azure/storage/__init__.py | |||
There was a problem hiding this comment.
You also need to add:
include azure/storage/blob/__init__.py
|
|
||
| # Per-module options: | ||
|
|
||
| [mypy-azure.storage.blob._generated.*] |
There was a problem hiding this comment.
i believe yes when using the latest autorest.
There was a problem hiding this comment.
@annatisch I think you are right, we don't need this since there's no _generated folder in changefeed package.
while why do we need [mypy-azure.core.*] will mypy throw error in dependency package?
sdk/storage/azure-storage-blob-changefeed/samples/change_feed_samples.py
Outdated
Show resolved
Hide resolved
| ServiceDirectory: storage | ||
| Artifacts: | ||
| - name: azure_storage_blob | ||
| safeName: azurestorageblob |
| #### Clients | ||
|
|
||
| The Blob ChangeFeed SDK provides one client: | ||
| ChangeFeedClient: get change feed events by page, get all change feed events, get events in a time range, start listing events with a continuation token |
There was a problem hiding this comment.
This section isn't rendering quite right - I think it needs a bullet point:
https://github.com/Azure/azure-sdk-for-python/blob/bae3f4aefd644fb974e016ab3fb355b19ad15316/sdk/storage/azure-storage-blob-changefeed/README.md#clients
Also description needs a capital and a final period.
sdk/storage/azure-storage-blob-changefeed/azure/storage/blob/changefeed/_change_feed_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob-changefeed/azure/storage/blob/changefeed/_change_feed_client.py
Outdated
Show resolved
Hide resolved
| self.unprocessed_segment_paths = [] | ||
| return None | ||
| return Segment(self.client, segment_path, page_size, segment_cursor) | ||
| return None |
There was a problem hiding this comment.
why do we need the last return None?
There was a problem hiding this comment.
self.current_segment = self._get_next_segment(.....)
because if there's no Segment we need to mark self.current_segment = None
…hangefeed/_change_feed_client.py Co-authored-by: Rakshith Bhyravabhotla <[email protected]>
…ent 'azure-storage-blob~=1.3'
|
you should be able to resolve the lint error once you rebase |
* [Storage]STG73 * [Blob][Swagger]Update Swagger (#10943) * [Blob][Swagger]Regenerate Swagger Code * fix container test failure caused by list_containers include type change * [Storage] Internal avro parser. (#10764) * initial avro parser * try fixing test... * falling in love with python compatibility... * make linter happy. * raise StopIteration when there is no more bytes instead of tracking file length. * async avro parser * fix syntax for Python 3.5 * get rid of 'readers_schema' as we only honor schema that has been written to file ('writer_schema'). * pr feedback * trim unused code. * pr feedback. * simplify skip sync in next. * move avro tests from _shared. * Jumbo blob support (#11176) * wip * initial test coverage. * wip. * wip * single upload. * add async tests. * disable 50k block tests. * datalake append. * async datalake * disable tests that send large payload over network. * pr feedback. * Undelete share (#11394) * Undelete container (#11339) * [Storage][Blob] Added support for Object Replication (#11525) * Blob versioning (#11154) * [Blob][QuickQuery]Add Quick Query Support (#10946) * [Blob][STG73]Blob Tags (#11418) * regenerate code (#11964) * fix the bug which caused only showing fatal error (#11997) * [Storage][STG73]Address API Review Comments (#12111) * [Storage][STG73]Address API Review Comments * [Storage][STG73]dict<policy, rules> -> list(ObjectReplicationPolicy) * fix blob tag_value test * expose ObjectReplicationPolicy and ObjectReplicationRule, fix test * fix test * Changefeed (#10755) * [ChangeFeed]Add ChangeFeed Package * test_avro failure * update dev_requirement.txt * change namespace to azure.storage.blob.changefeed * address comments * optimize memory when reading changefeed events * namespace change * set up package change * fix failed tests * readme and kwargs * Update sdk/storage/azure-storage-blob-changefeed/azure/storage/blob/changefeed/_change_feed_client.py Co-authored-by: Rakshith Bhyravabhotla <[email protected]> * address comments * 'azure-storage-blob>=12.3.0' which does not match the frozen requirement 'azure-storage-blob~=1.3' Co-authored-by: Rakshith Bhyravabhotla <[email protected]> * [Storage-Blob] Quick Query API (#11991) * Renamed query error * Renamed query reader * Updated config models * Updated format request params * Updated iterator * fix the bug which caused only showing fatal error * Updated Error message * Fixed query helper * Started test conversion * small fix * Fixed tests * Updated error handling + json model * Updated recordings * Removed old recording * Added iter tests * Iter test recordings * Fix test * Remove extra recording * Fix pylint * Some docs cleanup * Renamed iter_records -> iter_stream * Review feedback * Updated tests * Missing commas * Fix syntax * Fix pylint Co-authored-by: xiafu <[email protected]> * tag sas (#12258) * tag sas * disable undelete_container * pylint * skip undelete_container tests * [Blob][Versioning]Disable Versioning Live Test (#12281) * [Blob][QQ]Default output_format to input_format (#12283) * [Storage][Jumbo]Remove super (#12314) * [Storage][JumboBlob]remove empty super() * pypy3 * change sas version to latest * set tags account location to central canada * re-recording queue * changefeed paths generator * mark tests for vid as playback only * fix changefeed * fix pylint make the test account location for tags to central canada * add a delay before calling find_blobs_by_tags * remove tags header * mark a large file test playback only * revert "mark a large file test playback only" skip upload large file test address comment * move tag permission and filter_by_tags permission to kwargs Co-authored-by: Kamil Sobol <[email protected]> Co-authored-by: Ze Qian Zhang <[email protected]> Co-authored-by: Rakshith Bhyravabhotla <[email protected]> Co-authored-by: annatisch <[email protected]>
No description provided.