-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Closed
Labels
Azure.CoreClientThis issue points to a problem in the data-plane of the library.This issue points to a problem in the data-plane of the library.feature-requestThis issue requires a new behavior in the product in order be resolved.This issue requires a new behavior in the product in order be resolved.
Milestone
Description
Key Vault has custom diagnostic headers whose values are by default redacted by HttpLoggingPolicy. Preventing that redaction requires instantiating a policy then modifying its allow list:
Lines 29 to 32 in 2c8bfa1
| logging_policy = HttpLoggingPolicy(**kwargs) | |
| logging_policy.allowed_header_names.update( | |
| {"x-ms-keyvault-network-info", "x-ms-keyvault-region", "x-ms-keyvault-service-version"} | |
| ) |
It would be nice if the policy instead accepted these as optional keyword arguments, enabling usage like
HttpLoggingPolicy(additional_allowed_headers=["x-key-vault-stuff"])or
HttpLoggingPolicy(allowed_headers=HttpLoggingPolicy.DEFAULT_ALLOWED_HEADERS.union(["x-key-vault-stuff"]))Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Azure.CoreClientThis issue points to a problem in the data-plane of the library.This issue points to a problem in the data-plane of the library.feature-requestThis issue requires a new behavior in the product in order be resolved.This issue requires a new behavior in the product in order be resolved.