Skip to content

Commit 5cc0bea

Browse files
committed
update tests
1 parent b431bf1 commit 5cc0bea

3 files changed

Lines changed: 11 additions & 11 deletions

File tree

sdk/identity/identity/src/credentials/managedIdentityCredential/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ export class ManagedIdentityCredential implements TokenCredential {
255255
logger.info(`token = ${resultToken.token}`);
256256
return {
257257
accessToken: resultToken?.token,
258-
expiresInSeconds: resultToken?.expiresOnTimestamp,
258+
expiresInSeconds: resultToken?.expiresOnTimestamp/1000,
259259
};
260260
} else {
261261
logger.info(

sdk/identity/identity/test/internal/node/azureApplicationCredential.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ describe("AzureApplicationCredential testing Managed Identity (internal)", funct
114114
"URL does not have expected version"
115115
);
116116
if (authDetails.result?.token) {
117-
assert.equal(authDetails.result.expiresOnTimestamp, 1560999478000000);
117+
assert.equal(authDetails.result.expiresOnTimestamp, 1560999478000);
118118
} else {
119119
assert.fail("No token was returned!");
120120
}

sdk/identity/identity/test/internal/node/managedIdentityCredential.spec.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,7 @@ describe("ManagedIdentityCredential", function () {
560560
"URL does not have expected version"
561561
);
562562
if (authDetails.result?.token) {
563-
assert.equal(authDetails.result.expiresOnTimestamp, 1560999478000000);
563+
assert.equal(authDetails.result.expiresOnTimestamp, 1560999478000);
564564
} else {
565565
assert.fail("No token was returned!");
566566
}
@@ -598,7 +598,7 @@ describe("ManagedIdentityCredential", function () {
598598
"URL does not have expected version"
599599
);
600600
if (authDetails.result?.token) {
601-
assert.equal(authDetails.result.expiresOnTimestamp, 1624157878000000);
601+
assert.equal(authDetails.result.expiresOnTimestamp, 1624157878000);
602602
} else {
603603
assert.fail("No token was returned!");
604604
}
@@ -636,7 +636,7 @@ describe("ManagedIdentityCredential", function () {
636636
"URL does not have expected version"
637637
);
638638
if (authDetails.result?.token) {
639-
assert.equal(authDetails.result.expiresOnTimestamp, 1624157878000000);
639+
assert.equal(authDetails.result.expiresOnTimestamp, 1624157878000);
640640
} else {
641641
assert.fail("No token was returned!");
642642
}
@@ -977,7 +977,7 @@ describe("ManagedIdentityCredential", function () {
977977

978978
if (authDetails.result!.token) {
979979
// We use Date.now underneath.
980-
assert.equal(authDetails.result!.expiresOnTimestamp, 1000000);
980+
assert.equal(authDetails.result!.expiresOnTimestamp, 1000);
981981
} else {
982982
assert.fail("No token was returned!");
983983
}
@@ -1019,7 +1019,7 @@ describe("ManagedIdentityCredential", function () {
10191019

10201020
if (authDetails.result!.token) {
10211021
// We use Date.now underneath.
1022-
assert.equal(authDetails.result!.expiresOnTimestamp, 1000000);
1022+
assert.equal(authDetails.result!.expiresOnTimestamp, 1000);
10231023
} else {
10241024
assert.fail("No token was returned!");
10251025
}
@@ -1046,7 +1046,7 @@ describe("ManagedIdentityCredential", function () {
10461046
assert.equal(confidentialSpy.callCount, 1);
10471047

10481048
if (authDetails.result?.token) {
1049-
assert.equal(authDetails.result.expiresOnTimestamp, 1560999478000000);
1049+
assert.equal(authDetails.result.expiresOnTimestamp, 1560999478000);
10501050
} else {
10511051
assert.fail("No token was returned!");
10521052
}
@@ -1101,7 +1101,7 @@ describe("ManagedIdentityCredential", function () {
11011101
);
11021102
assert.strictEqual(decodeURIComponent(body.get("scope")!), "https://service/.default");
11031103
assert.strictEqual(authDetails.result!.token, "token");
1104-
assert.strictEqual(authDetails.result!.expiresOnTimestamp, 1000000);
1104+
assert.strictEqual(authDetails.result!.expiresOnTimestamp, 1000);
11051105
});
11061106
it("reads from the token file again only after 5 minutes have passed", async function (this: Mocha.Context) {
11071107
// Keep in mind that in this test we're also testing:
@@ -1198,7 +1198,7 @@ describe("ManagedIdentityCredential", function () {
11981198
// For this reason, there is no subsequent requests being passed as before to the STS,
11991199
// since the token is already retrieved from the double caching.
12001200
assert.equal(authDetails.requests.length, 0);
1201-
assert.equal(authDetails.result?.expiresOnTimestamp, 1000000);
1201+
assert.equal(authDetails.result?.expiresOnTimestamp, 1000);
12021202
assert.equal(authDetails.result?.token, "token");
12031203

12041204
// More than 5 minutes means we read the file again.
@@ -1216,7 +1216,7 @@ describe("ManagedIdentityCredential", function () {
12161216
],
12171217
});
12181218
assert.equal(authDetails.requests.length, 0);
1219-
assert.equal(authDetails.result?.expiresOnTimestamp, 1000000);
1219+
assert.equal(authDetails.result?.expiresOnTimestamp, 1000);
12201220
assert.equal(authDetails.result?.token, "token");
12211221
});
12221222

0 commit comments

Comments
 (0)