Replaced relative link with absolute links and remove locale#15285
Replaced relative link with absolute links and remove locale#15285weshaggard merged 3 commits intoAzure:masterfrom
Conversation
|
/azp run java - aggregate-reports |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
sima-zhu
force-pushed
the
disable_relative_link
branch
7 times, most recently
from
8b4eb0b to
32e609a
Compare
sima-zhu
changed the title
sima-zhu
requested review from
ChenTanyi,
David-Noble-at-work,
abhipsaMisra,
alzimmermsft,
amishra-dev,
anuchandy,
arerlend,
azabbasi,
barustum,
bgklein,
bikamani,
bsiegel,
chenrujun,
conniey,
danieljurek,
drwill-ms,
g2vinay,
gapra-msft and
hemanttanwar
as code owners
sima-zhu
removed request for
jialindai,
kasobol-msft,
weidongxu-microsoft,
xinlian12,
xseeseesee and
yiliuTo
mssfang
left a comment
mssfang
left a comment
There was a problem hiding this comment.
LGTM for AppConfig, TextAnalytics and FormRecognizer changes! Thanks Sima.
weidongxu-microsoft
left a comment
weidongxu-microsoft
left a comment
There was a problem hiding this comment.
Thanks for the help!
|
I was expecting you to enable the link guidance as part of this PR so that we can confirm that we have all the links fixed, but I didn't see that as part of this PR. |
|
/azp run java - aggregate-reports |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Manually triggered java - aggregate-reports jobs https://dev.azure.com/azure-sdk/internal/_build/results?buildId=542853&view=logs&j=ad792ccc-30b2-59a1-5b53-546a79d88828 to verify. |
| - template: ../../../common/pipelines/templates/steps/verify-links.yml | ||
| parameters: | ||
| Directory: sdk/${{ parameters.ServiceDirectory }} | ||
| CheckLinkGuidance: $true |
There was a problem hiding this comment.
I suspect this might also need to be set for the aggregate-reports pipeline.
There was a problem hiding this comment.
I did not enable aggregate-report yml. Will trigger the aggregate-report again once I check in the changes.
There was a problem hiding this comment.
I'm Ok with that as long as you quickly follow-up on any broken links as I want to make sure we don't accidently break any pipelines.
There was a problem hiding this comment.
I plan to work on lang repos subsequently as work altogether will cause a spike unfortunately.
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Quick scan looks good. Lets wait for the java - aggregate-reports pipeline so it can validate all the links in the repo
|
@sima-zhu I'm going to force merge this right now. Please follow-up with a change the aggregate-reports pipeline to enable the guidance so that we can ensure there are no other breaks. |
This is the final step of link verification epic. Enable the link guidance check for all Ci pipelines. The PR is pending for all lang PRs: java: Azure/azure-sdk-for-java#15285 net: Azure/azure-sdk-for-net#15223 python: Azure/azure-sdk-for-python#13846 js: Azure/azure-sdk-for-js#11317 ios: Azure/azure-sdk-for-ios#433 android: Azure/azure-sdk-for-android#348 go: Azure/azure-sdk-for-go#12541 cpp: Azure/azure-sdk-for-cpp#632 c: Azure/azure-sdk-for-c#1296
This is the final step of link verification epic. Enable the link guidance check for all Ci pipelines. The PR is pending for all lang PRs: java: Azure/azure-sdk-for-java#15285 net: Azure/azure-sdk-for-net#15223 python: Azure/azure-sdk-for-python#13846 js: Azure/azure-sdk-for-js#11317 ios: Azure/azure-sdk-for-ios#433 android: Azure/azure-sdk-for-android#348 go: Azure/azure-sdk-for-go#12541 cpp: Azure/azure-sdk-for-cpp#632 c: Azure/azure-sdk-for-c#1296
6 participants
The PR is to turn on the link check flag.
Pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=541050&view=logs&j=ad792ccc-30b2-59a1-5b53-546a79d88828&t=98098dc8-5acb-5f94-5428-670dacfec5e2