feat(toolboxes): support new preview tools#9229
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 21 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
📋 Prioritization NoteThanks for the contribution! The linked issue isn't in the current milestone yet. |
There was a problem hiding this comment.
Pull request overview
Adds support for new Foundry preview tools in toolbox creation and connection listing.
Changes:
- Verifies preview tool definitions pass through unchanged.
- Recognizes any top-level
project_connection_id. - Adds coverage for WorkIQ and FabricIQ connection rows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
toolbox_connection_list.go |
Generalizes connection-backed tool detection. |
toolbox_helpers_test.go |
Tests preview-tool connection extraction. |
toolbox_commands_test.go |
Tests preview-tool creation pass-through. |
jongio
left a comment
jongio
left a comment
There was a problem hiding this comment.
Reviewed the change. Generalizing extractConnectionTools to surface any tool with a top-level project_connection_id is the right call over the previous hardcoded mcp/a2a_preview list, and it stays forward-compatible with future preview tool types. The azure_ai_search and web_search cases keep working since their connection IDs are nested rather than top-level, so they still fall through to their own expansion logic. Test coverage on both the create pass-through and the connection-list extraction looks good.
Summary
Fixes #8191. Toolbox creation already forwards new Foundry tool shapes, but connection listing omitted WorkIQ and FabricIQ tools.
Changes
toolbox create: verifywork_iq_preview,fabric_iq_preview, andtoolbox_search_previewpass through unchanged.toolbox connection list: surface any tool with a top-levelproject_connection_idinstead of restricting the recognized tool types.Manual Validation
toolbox showpreserved their fields.toolbox connection listreturned the WorkIQ and FabricIQ connections.azure.yaml, ranazd deploy, and confirmed connection resolution, field round-tripping, endpoint output, and connection listing.