-
Notifications
You must be signed in to change notification settings - Fork 332
add 'azd ai agent sample list' to browse templates and improve non-interactive init #8266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2318459
feat(agents): add catalog discovery subcommand and improve error hand…
therealjohn dc1f25c
feat(agents): update output format to use 'text' instead of 'table' a…
therealjohn 2a4dccf
feat(agents): enhance normalizeOutputFormat to clarify allowed output…
therealjohn 2535d4e
fix: resolve lint warnings
therealjohn 5656c0e
fix: remove unnecessary variable declaration in TestValidateInitListF…
therealjohn 3a5c479
feat(agents): improve output handling and diagnostics in init commands
therealjohn 5889780
Address PR review feedback for #8266
therealjohn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
cli/azd/extensions/azure.ai.agents/internal/cmd/index_helpers.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| package cmd | ||
|
|
||
| import "math" | ||
|
|
||
| // boundedInt32Index converts a slice index into the int32 form expected by the | ||
| // azdext Select API (SelectedIndex / *resp.Value). | ||
| // | ||
| // All callers in this package index into small, statically-bounded slices | ||
| // (enum values, resource tiers, curated template lists, model name lists) | ||
| // where overflow is impossible. Routing every such conversion through this | ||
| // one helper keeps the gosec G115 suppression in a single place and makes | ||
| // the safety argument explicit: | ||
| // | ||
| // - Indices are non-negative (returned by range over a slice). | ||
| // - Slice lengths are bounded well below math.MaxInt32 at every call site. | ||
| // | ||
| // The defensive clamp below means a future caller that violates the | ||
| // invariant returns the safe default (index 0 = first option) instead of | ||
| // panicking or wrapping. | ||
| func boundedInt32Index(i int) int32 { | ||
| if i < 0 || i > math.MaxInt32 { | ||
| return 0 | ||
| } | ||
| return int32(i) //nolint:gosec // G115: bounds enforced by the check above | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.