Add actionable suggestions and multi-line formatting to preflight warnings (#8059) * wip * Add actionable suggestions and multi-line formatting to preflight warnings Extend preflight warnings with optional Suggestion and Links fields so that each warning can provide context-specific, actionable next steps. This is the first step of the validation improvement roadmap (actionable suggestions → targeted fixes → agentic fixes). Changes: - Add Suggestion/Links fields to PreflightCheckResult and PreflightReportItem - Render suggestions and links below each warning in ToString() - Include structured suggestion data in MarshalJSON() for machine consumption - Generate dynamic suggestions for AI quota warnings: - ai_model_not_found: verify model/SKU/version + docs link - ai_model_quota_exceeded: reduce capacity or change location + portal link - Add suggestions to role_assignment and reserved_resource_name warnings - Reformat all warnings to two-line layout (title + detail) with proper indentation on continuation lines - Update confirm prompt to be more concise - Add unit tests for suggestion rendering, multi-line indentation, and JSON Fixes #8058 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: address Copilot review feedback (iteration 1) - Fix writeItem doc comment to match actual indentation behavior - Strip ANSI escape sequences from Message/Suggestion in MarshalJSON - Use partition ordering (warnings-first) in MarshalJSON to match ToString - Add test for ANSI stripping and ordering verification Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add snapshot tests for preflight warning rendering Add 6 snapshot tests covering each warning diagnostic type individually plus one combined test showing all warnings together: - role_assignment_missing (with suggestion) - role_assignment_conditional (no suggestion) - reserved_resource_name (with links, no suggestion) - ai_model_not_found (with suggestion and links) - ai_model_quota_exceeded (with suggestion and links) - all warnings combined Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: address Copilot review feedback (iteration 3) - Fix import ordering: stdlib → external → internal - Revert MarshalJSON to use EventEnvelope via EventForMessage for consistency with the --output json JSONL event stream - Preallocate links slice in validatePreflight Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: address Copilot review feedback (iteration 4) - Fix import ordering in test file: stdlib → external → internal - Update PR description to match actual MarshalJSON behavior Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: address Copilot review feedback (iteration 5) - Update PreflightReportLink.Title doc comment to note terminal-only behavior Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: address Copilot review feedback (iteration 6) - Guard writeItem against empty message to prevent rendering empty prefix - Align PreflightCheckLink.Title doc comment with UX counterpart Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: address Copilot review feedback (iteration 7) - Handle zero remaining quota in suggestion text: show 'No quota is available' instead of misleading 'Reduce capacity to 0' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: therealjohn <1501196+therealjohn@users.noreply.github.com>

Uh oh!

Add suggestions to local-preflight warnings #8058

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions