add test for paging while overriding api version#387
Merged
iscai-msft merged 3 commits intomainfrom Jun 21, 2022
Merged
Conversation
lmazuel
approved these changes
Jun 21, 2022
Member
|
If the client sends the initial request with the right API version, shouldn't the service respond with a next link where the exact API version is appended? Is there a reason for the service not to? |
Contributor
Author
|
@deyaaeldeen the REST behavior here has been not consistent (and the language sdk behaviors have not been consistent either). After talking with @JeffreyRichter , we want to always attach the api version of the client onto these paging calls |
iscai-msft
added a commit
that referenced
this pull request
Jun 22, 2022
…nto paging_maxpagesize * 'main' of https://github.com/Azure/autorest.testserver: add test for paging while overriding api version (#387)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the client has an api version, we want to 1. append that api version to the next link if it doesn't exist OR 2. override the returned api version with that api version.
This test tests that we overide the returned api version in the next link, while preserving the other query parameter returned in the next link