Fix stdin passthrough when running start.py through run-python3#674
Closed
daviwil wants to merge 2 commits intoAzure:autorestv3from
Closed
Fix stdin passthrough when running start.py through run-python3#674daviwil wants to merge 2 commits intoAzure:autorestv3from
daviwil wants to merge 2 commits intoAzure:autorestv3from
Conversation
daviwil
force-pushed
the
fix-run-python3
branch
2 times, most recently
from
d98ffe5 to
cc72d96
Compare
Contributor
|
looks good to me! |
Contributor
Author
|
Awesome! Now I just need to figure out why GitHub thinks there's a merge conflict 😅 |
Contributor
I think it's because I swooped you with another PR 😅 |
Contributor
Author
|
Ahhh, no problem! I'll rebase. |
Contributor
Author
|
I swear I rebased but GitHub did something weird. Anyway, it's mergeable now :) |
Contributor
Author
|
Recreating the PR with a branch from this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change (hopefully) fixes the
run-python3.jsscript so that it completes installation and successfully launchesstart.py. @iscai-msft, do you mind giving this a try? I verified that it works on my machine after runningnpm packand thenuse-ing that package in anautorestrun.