Skip to content

deal with optional return types correctly#656

Merged
iscai-msft merged 11 commits intoautorestv3from
optional_return_type
May 29, 2020
Merged

deal with optional return types correctly#656
iscai-msft merged 11 commits intoautorestv3from
optional_return_type

Conversation

@iscai-msft
Copy link
Contributor

@iscai-msft iscai-msft commented May 28, 2020

fixes #657 and fixes #658
We now also only generate deserialized = None before multiple responses if there is an optional return type. Otherwise, we know that deserialized will be deserialized based on its status code

Return type typing annotation are also corrected

@iscai-msft iscai-msft requested a review from lmazuel May 28, 2020 17:20
@iscai-msft iscai-msft merged commit c540bda into autorestv3 May 29, 2020
@iscai-msft iscai-msft deleted the optional_return_type branch May 29, 2020 22:37
iscai-msft added a commit that referenced this pull request Jun 4, 2020
…into improve_multiapi_lro_paging_docstring

* 'autorestv3' of https://github.com/Azure/autorest.python:
  LRO Continuation Token [need azure-core 1.6.0] (#565)
  fix http request verb to always be get for next operation if not defined (#664)
  Fix generation of pkgutil files (#661)
  deal with optional return types correctly (#656)
  include new testserver test for paging model whose item name has an x-ms-client-name (#654)
iscai-msft added a commit that referenced this pull request Jun 12, 2020
…into add_nullable_to_validation_map

* 'autorestv3' of https://github.com/Azure/autorest.python: (59 commits)
  Support other auth policies (#686)
  correct return type for head operations (#680)
  update mypy.ini (#670)
  import models in operation group if there are just enums (#676)
  add type annotation for empty class model definitions in service client (#672)
  add type ignore to patch file import (#671)
  don't generate namespace test when generating individual swaggers (#683)
  Update package.json
  Update ChangeLog.md
  Fix stdin passthrough when running start.py through run-python3 (#678)
  update to latest testserver (#673)
  Add unicode test routes (#668)
  Generate correct docstrings for paging and LRO operations (#652)
  add missing license headers (#667)
  LRO Continuation Token [need azure-core 1.6.0] (#565)
  fix http request verb to always be get for next operation if not defined (#664)
  Fix generation of pkgutil files (#661)
  deal with optional return types correctly (#656)
  include new testserver test for paging model whose item name has an x-ms-client-name (#654)
  added generating wiki to readme for better access (#646)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants