Lro multiapi merge imports#651
Merged
lmazuel merged 6 commits intolro_continuation_tokenfrom May 27, 2020
Merged
Conversation
…orest.python into lro_continuation_token * 'lro_continuation_token' of https://github.com/Azure/autorest.python: LRO continuation token typing and doc fixes (#645)
…orest.python into lro_continuation_token * 'lro_continuation_token' of https://github.com/Azure/autorest.python: LRO handling in multiapi with async LROPoller (#649)
iscai-msft
added a commit
that referenced
this pull request
May 27, 2020
…orest.python into lro_continuation_token * 'lro_continuation_token' of https://github.com/Azure/autorest.python: Lro multiapi merge imports (#651)
lmazuel
added a commit
that referenced
this pull request
Jun 3, 2020
* LRO Continuation Token * Test * No print * Async poller * Async continuation token tests * Remove not-begin approach * Move back lro_delay extract * Update tests to begin_ in async * Feedback * Feedback regeneration * added continuation_token to reserved parameters * Making it a 5.1.0-preview.1 * 5.1.0 preview.1 changelog * Update dependencies * Fix more tests * Regenerate * More dep changes * fixed async docs and typing * added return type to LROPoller sync typing * LRO continuation token typing and doc fixes (#645) * fixed async docs and typing * added return type to LROPoller sync typing * LRO handling in multiapi with async LROPoller (#649) * fixed async docs and typing * added return type to LROPoller sync typing * fixed handling of LRO in multiapi * fixed return type for async functions * Lro multiapi merge imports (#651) * fixed async docs and typing * added return type to LROPoller sync typing * merging imports across all versions for multiapi mixins * fixed pylint and mypy * azure-core 1.6.0 is released * Upgrade changelog * Last testserver * Missing folder Co-authored-by: iscai-msft <[email protected]> Co-authored-by: iscai-msft <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I duplicated the imports model and file import serializer.
I already had a past issue for a separate plugin to avoid duplicating code across multiapi and codegen, updated and will try to add these files to the separate plugin: #513
Right now, there are imports we're not using in the operations mixin. I've added an issue to fix this: #650