hide operations with > 2 body types#1300
Merged
iscai-msft merged 12 commits intoautorestv3from Jun 14, 2022
Merged
Conversation
iscai-msft
commented
Jun 13, 2022
| self.is_overload: bool = yaml_data["isOverload"] | ||
| self.api_versions: List[str] = yaml_data["apiVersions"] | ||
|
|
||
| if code_model.options["version_tolerant"] and yaml_data.get("abstract"): |
Contributor
Author
There was a problem hiding this comment.
basically moved abstract marking code to m4reformatter, and moved the warning to base builder. This centralizes our code more
…into hide_three_types * 'autorestv3' of https://github.com/Azure/autorest.python: remove dpg legacy generation (#1298)
|
|
||
| if code_model.options["version_tolerant"] and yaml_data.get("abstract"): | ||
| _LOGGER.warning( | ||
| 'Not going to generate operation "%s" because it we are unable to generate this ' |
Member
There was a problem hiding this comment.
nit: "because it" --> "because"?
Contributor
Author
There was a problem hiding this comment.
thanks! my sentence really didn't make much sense 🤣
iscai-msft
added a commit
that referenced
this pull request
Jun 23, 2022
…into full_pipeline_cadl * 'autorestv3' of https://github.com/Azure/autorest.python: (35 commits) nosec bandit code (#1324) pin isodate to major version (#1321) Dont generate maxpagesize (#1320) reformat api-version into next link if its a client param (#1309) Update ChangeLog.md (#1310) Update ChangeLog.md Update package.json Update ChangeLog.md just do get call to next link for single operation dpg paging (#1307) Update ChangeLog.md remove lowlevel client test (#1303) default to version tolerant (#1304) Fix changelog date (#1302) hide operations with > 2 body types (#1300) update min dependency for `msrest` (#1301) remove dpg legacy generation (#1298) update flags (#1297) Update package.json Update ChangeLog.md Update ChangeLog.md ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1263
TODO: adding tests, will add tomorrow