Merged
Conversation
iscai-msft
commented
Sep 25, 2021
| def _convert_request(request, files=None): | ||
| data = request.content if not files else None | ||
| request = HttpRequest(method=request.method, url=request.url, headers=request.headers, data=data) | ||
| if files: |
Contributor
Author
There was a problem hiding this comment.
since the properties files and data are legacy properties, decided not to go with them. With our new request's content property, we don't distinguish between "files" and "data", which we need to for old requests. So here, if we're using files (which people very rarely do), we do an additional set_formdata_body here
iscai-msft
commented
Sep 27, 2021
| # -------------------------------------------------------------------------- | ||
|
|
||
| from ._paging_operations import PagingOperations | ||
| from azure.core.pipeline.transport import HttpRequest |
Contributor
Author
There was a problem hiding this comment.
There are some weird diffs going on here. Basically, I realized I had a duplicate out-of-date CustomPollerPager in my version tolerant folder, so I deleted it, which for some reason has caused these weird diffs
iscai-msft
added a commit
that referenced
this pull request
Sep 28, 2021
…into update_for_core * 'autorestv3' of https://github.com/Azure/autorest.python: vendor request conversion (#1048)
iscai-msft
added a commit
that referenced
this pull request
Sep 28, 2021
…into remove_metadata_version_tolerant * 'autorestv3' of https://github.com/Azure/autorest.python: Update package.json Update ChangeLog.md fix spacing run all tests and don't regenerate vendor request conversion (#1048)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.