fix model docstring to use keyword instead of param#1026
Merged
iscai-msft merged 2 commits intoautorestv3from Sep 8, 2021
Merged
fix model docstring to use keyword instead of param#1026iscai-msft merged 2 commits intoautorestv3from
iscai-msft merged 2 commits intoautorestv3from
Conversation
tjprescott
changed the title
Member
|
Can we verify what impact, if any, this would have on |
Member
|
This PR addresses: |
tjprescott
reviewed
Sep 8, 2021
Member
There was a problem hiding this comment.
This looks great to me, but we should assess any impact on generated docs. Thanks @iscai-msft
tjprescott
approved these changes
Sep 8, 2021
Member
tjprescott
left a comment
tjprescott
left a comment
There was a problem hiding this comment.
I verified that this change didn't produce any difference in the display of generated docs, so I am happy with this change. Thank you @iscai-msft!
johanste
approved these changes
Sep 8, 2021
Member
johanste
left a comment
johanste
left a comment
There was a problem hiding this comment.
I'll admit I didn't go through all the acceptance tests in detail.
Contributor
Author
|
sounds good @johanste. I'll merge this one since it's approved, will work on adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.