Skip to content

Populate repo with initial sources#1

Merged
philon-msft merged 6 commits into
mainfrom
philon-msft/initial
May 9, 2023
Merged

Populate repo with initial sources#1
philon-msft merged 6 commits into
mainfrom
philon-msft/initial

Conversation

@philon-msft

Copy link
Copy Markdown
Contributor

No description provided.

@NickCraver NickCraver left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I left a few polish comments/suggestions (happy to PR as well) but this is in great shape <3

Comment thread sample/Sample.cs
Comment thread src/AzureCacheForRedis.cs Outdated
Comment thread src/AzureCacheOptions.cs Outdated
Comment thread src/AzureCacheOptions.cs Outdated
Comment thread src/AzureCacheOptionsProviderWithToken.cs Outdated
Comment thread src/Microsoft.Azure.StackExchangeRedis.csproj Outdated
Comment thread tests/Microsoft.Azure.StackExchangeRedis.Tests.csproj Outdated

@NickCraver NickCraver left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Some notes in DM about sample cleanup but that's super minor - awesome job on this <3

@philon-msft philon-msft merged commit 177bcea into main May 9, 2023
@philon-msft philon-msft deleted the philon-msft/initial branch May 9, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants