Feature: Gallery applications(NCJ)#785
Merged
timotheeguerin merged 32 commits intomasterfrom Oct 18, 2017
Merged
Conversation
* Added market icon and page * Added page navigation functionality to Market * made Market into two pages * Load and render data from template Json files * Form UI created with default values populated, Submit button grabs inputs and console logs them. * added Python RPC * NCJ runs on submission * css changes * added css styles and refactor code * auth changes * New auth * List applications then actions * wip * refactor * more * Better home * pick market * Show application * added job template form wiring * created submit form for job template * larger style * No actions message * better search * fix style * wip * More * Advanced type * Name * Show hints * Wip * More * wip * fix job submit * fix submit butn * fix hint * Submit app * Better error handling * refresh keep form inputs * Works * Force update application from github * Choose list * Fix test * Reconnect to websocket server * Will try to reconnect on request if needed * fix build * fix errors
* added icon to 2nd page * added mode selection to form * created buttons for mode options * comment out unnecessary code * combined job parameters and pool paramerters in some form group * uncomment * form is set to form group * created different forms for different modes * forms works with different input types but no RPC * fix dependsOn * market submissions works for all three modes * added tlint changes * added tlint changes * rpc error handling * code review changes * separated job and pool params from form * convert functions used in html to public * removed comments and changed private variables to public * changed double equals to triple equals * replaced if to switch statements * fix * fixed redirection * fix bug with loading button * added back NcjParameter Class * implemented parameter wrapper * added an empty component for parameters * adding content in parameter-input component * added type * added ControlValueAccessor * completed parameter input component * spacing * changes * Missing file * remove : * added empty unit test for parameter input component * remove console logs * added unit test for parameter input component * line spacing * added unit tests for market-application model * code review changes * more code review changes * more code review changes * updated unit test name * fix multiple imports
* added validation logic and refactored * submit button only activates when form is valid * added return type * added unit tests and completed form validation * code review * added unit test for validation * updated error messages * made error message more user friendly * made error message even more friendlier * error message spelling
* remove validator when default is empty string * remove console log * added exists
* Show more details for the python errors * Remove console.log * fix pylint
Merge branch 'ncj' of https://github.com/Azure/BatchLabs into ncj Fix Fix Fix Fix Fix fix fix
* Recent template working * Recent template submissions * Fix * Fix * Fix * Tweak * remove console.log * Fix * Fix issue * Fix issue
* allow user to create filegroup from job tmeplate form * add option to create group in options list * add option to create group in options list (with files this time) * style tweak * remove buttons, auto set container name, validate after reload * dont get value from form * fix test * argh, fdescribe
timotheeguerin
commented
Oct 17, 2017
.travis.yml
Outdated
| only: | ||
| - master | ||
| - stable | ||
| - ncj # remove when merging ncj |
timotheeguerin
commented
Oct 17, 2017
scripts/travis/build-and-test.sh
Outdated
|
|
||
| # Only package if on stable branch | ||
| if [ "${TRAVIS_PULL_REQUEST}" = "false" ] && [ "${TRAVIS_BRANCH}" = "stable" ]; then | ||
| if [ "${TRAVIS_PULL_REQUEST}" = "false" ] && ([ "${TRAVIS_BRANCH}" = "stable" ] || [ "${TRAVIS_BRANCH}" = "ncj" ]); then |
timotheeguerin
commented
Oct 17, 2017
package.json
Outdated
| "email": "[email protected]" | ||
| }, | ||
| "version": "0.7.0", | ||
| "version": "0.8.0-ncj", |
timotheeguerin
commented
Oct 17, 2017
appveyor.yml
Outdated
| npm run -s package -- --publish always --draft --win | ||
| ) ELSE ( | ||
| npm run -s package -- --publish never | ||
| npm run -s package -- --publish always --draft --win |
* Disable market if storage account is not added * Fix
timotheeguerin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #786