grammar issues and fix blob file explorer#721
Merged
Conversation
| nodeNavigator.init(); | ||
|
|
||
| const taskOutputPrefix = `${this.task.id}/`; | ||
| const taskOutputPrefix = `${this.task.id}`; |
Member
There was a problem hiding this comment.
I think we should make the command support having a basePath ending or not with / instead of joining / and then breaking that.
Member
Author
There was a problem hiding this comment.
agree though i don't think there is any need to have a / here either. given that at the moment the prefix is only used by blob storage queries and the prefix has never ended in a / before. So i suggest we remove it here and also make the command handle having a path segment ending in a /
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change a couple of words in notifications
fix the blob file explorer by removing training slash that was messing up the storage prefix.