Conversation
|
This is missing a milestone. |
| this.changeDetector.markForCheck(); | ||
| }); | ||
|
|
||
| setTimeout(() => { |
There was a problem hiding this comment.
Shouldn't you be discarding this timeout when you navigate away from the component?
| // [FileType.log]: ["txt", "log"], | ||
| // [FileType.image]: ["png", "jpg", "gif"], | ||
| // [FileType.code]: ["json", "ts2", "js", "java", "cs", "cpp", "h", "hpp", "py", "xml", "sh", "cmd", "bat"], | ||
| // }; |
|
|
||
| public userSettingsEditorConfig: CodeMirror.EditorConfiguration = { | ||
| lineNumbers: true, | ||
| mode: "application/javascript", |
There was a problem hiding this comment.
Why are we using json above, but javascript here?
| gutters: ["CodeMirror-lint-markers"], | ||
| lint: true, | ||
| extraKeys: { | ||
| "Ctrl-S": this.save, |
There was a problem hiding this comment.
I saw above you were adding Ctrl-/ in code. Should it be added here?
There was a problem hiding this comment.
yeah ctrl+/ is added for all language but the save depends on the usage of the editor
|
|
||
| @autobind() | ||
| private _validJsonConfig(c: FormControl): Promise<any> { | ||
| clearTimeout(this._validateDebounceTimeout); |
There was a problem hiding this comment.
does clearTimeout() care if this._validateDebounceTimeout is undefined?
| @@ -1,8 +1,8 @@ | |||
| export interface Settings { | |||
| homePage: "account" | "home" | "job"; | |||
| export enum Theme { | |||
There was a problem hiding this comment.
While this looks nice to have in the settings, is it worth exposing if we only have 1??
There was a problem hiding this comment.
I guess we can remove it
app/utils/extensions/json.ts
Outdated
| if (!JSON.minify) { | ||
| JSON.minify = (json) => { | ||
|
|
||
| let tokenizer = /"|(\/\*)|(\*\/)|(\/\/)|\n|\r/g; |
There was a problem hiding this comment.
??? What? Please add some comments describing what this does.
There was a problem hiding this comment.
removed it and used strip-json-comments library
3 participants
fix #472
