Quick add file auto focus and close autocomplet on blur#517
Merged
timotheeguerin merged 4 commits intomasterfrom Jul 5, 2017
Merged
Quick add file auto focus and close autocomplet on blur#517timotheeguerin merged 4 commits intomasterfrom
timotheeguerin merged 4 commits intomasterfrom
Conversation
ascobie
reviewed
Jun 27, 2017
| ? this._options.value.filter(option => new RegExp(`${nameFilter}`, "gi").test(option)) | ||
| : this._options.value; | ||
| }); | ||
| } |
Member
There was a problem hiding this comment.
nitpick, is this an extra space added to this method?
(edit), oh looks like it was out of alignment to begin with ...
Member
Author
There was a problem hiding this comment.
yep seems like so, not sure why tslint is not catching that
ascobie
approved these changes
Jun 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #486