Replaces keytar with Electron's safeStorage API#2995
Merged
Conversation
gingi
requested review from
NickKouds,
ReneOv-MSFT,
cRui861,
dpwatrous,
skapur12,
wanghoppe,
wiboris and
zfengms
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2995 +/- ##
==========================================
- Coverage 80.30% 80.27% -0.03%
==========================================
Files 1462 1466 +4
Lines 46181 46366 +185
Branches 5785 5797 +12
==========================================
+ Hits 37084 37222 +138
- Misses 8910 8955 +45
- Partials 187 189 +2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
gingi
force-pushed
the
shpaster/replace-keytar
branch
6 times, most recently
from
703fb1c to
065bceb
Compare
Adds renderer SafeStorageService and IPC events
gingi
force-pushed
the
shpaster/replace-keytar
branch
from
065bceb to
ddea64c
Compare
dpwatrous
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to secure credential storage, including enhanced encryption algorithms, better handling of legacy encrypted data, and user-facing notifications for when secure storage is unavailable. It also adds new tests and refactors the secure storage abstraction for better reliability and maintainability.
Refactored
CryptoServiceto support both legacy (AES-256-CTR, 16-byte key) and current (AES-256-GCM, 32-byte key) encryption algorithms, ensuring backward compatibility and improved security. The encryption format now includes a version header for future extensibility.Added a warning banner to the welcome screen when secure credential storage is unavailable, including clear instructions for Linux users to install
libsecret.Replaced direct
keytarusage with a newKeytarServicethat delegates toSafeStorageService, making credential storage easier to mock and more robust against platform differences.Added comprehensive unit tests for
KeytarService, verifying correct delegation and error handling in credential storage.