Skip to content

Lock node comms form to old API version#2992

Merged
dpwatrous merged 1 commit intomainfrom
dpwatrous/lock-node-comms-api
Nov 11, 2025
Merged

Lock node comms form to old API version#2992
dpwatrous merged 1 commit intomainfrom
dpwatrous/lock-node-comms-api

Conversation

@dpwatrous
Copy link
Member

@dpwatrous dpwatrous commented Nov 10, 2025

The next API version will remove support for node communication mode properties. This PR will keep the UI for updating node communications mode working by locking the code to the 2024-07-01 API version.

zfengms
zfengms previously approved these changes Nov 10, 2025
@dpwatrous dpwatrous force-pushed the dpwatrous/lock-node-comms-api branch from 71082f4 to a2ceeca Compare November 11, 2025 17:28
@dpwatrous dpwatrous requested a review from zfengms November 11, 2025 17:53
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.32%. Comparing base (ccf3a6e) to head (a2ceeca).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/service/src/pool/live-pool-service.ts 42.85% 6 Missing and 2 partials ⚠️
packages/service/src/test-util/fakes.ts 64.28% 4 Missing and 1 partial ⚠️
...ckages/react/src/pool/update-node-comms-action.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2992      +/-   ##
==========================================
- Coverage   80.34%   80.32%   -0.02%     
==========================================
  Files        1462     1462              
  Lines       46115    46147      +32     
  Branches     5773     5780       +7     
==========================================
+ Hits        37049    37068      +19     
- Misses       8883     8893      +10     
- Partials      183      186       +3     
Files with missing lines Coverage Δ
packages/service/src/pool/fake-pool-service.ts 100.00% <100.00%> (ø)
packages/service/src/pool/pool-models.ts 100.00% <ø> (ø)
...ckages/react/src/pool/update-node-comms-action.tsx 86.66% <66.66%> (ø)
packages/service/src/test-util/fakes.ts 70.40% <64.28%> (-1.03%) ⬇️
packages/service/src/pool/live-pool-service.ts 72.91% <42.85%> (-12.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf3a6e...a2ceeca. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dpwatrous dpwatrous merged commit d048540 into main Nov 11, 2025
8 checks passed
@dpwatrous dpwatrous deleted the dpwatrous/lock-node-comms-api branch November 11, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants